Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_UPLOAD_SIZE broken when more than one upstream #9

Open
jperville opened this issue Jan 2, 2015 · 2 comments
Open

MAX_UPLOAD_SIZE broken when more than one upstream #9

jperville opened this issue Jan 2, 2015 · 2 comments
Labels

Comments

@jperville
Copy link

I tried to use the MAX_UPLOAD_SIZE feature for a virtualhost with 2 load-balanced upstream containers. It was broken because of nginx syntax error, as explained below.

The current nginx template will output as many client_max_body_size directives as there are containers, which means nginx -t will fail to parse the configuration in /etc/nginx/sites-enabled/default ; in the best case the old configuration will keep being used and in the worst case the container won't start at all.

I have proposed nginx-proxy#76 to solve the issue, feel free to port the fix to your fork too.

@zedtux
Copy link
Owner

zedtux commented Jan 2, 2015

Nice, thank you @jperville I will port the fix to my fork.

@zedtux zedtux added the bug label Jan 2, 2015
@zedtux
Copy link
Owner

zedtux commented Jun 14, 2018

This repository has been migrated to GitLab and this issue too. Move to the right place now!

Repository owner locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants