From cabcd77cb0f8a9b8608540bf94482d34dc1c6396 Mon Sep 17 00:00:00 2001 From: Alex Strick van Linschoten Date: Mon, 23 Sep 2024 10:33:12 +0200 Subject: [PATCH] remove python 3.8 support --- .github/workflows/ci.yml | 12 ++++++------ .github/workflows/lint-unit-test.yml | 19 +++---------------- .github/workflows/publish-pypi-package.yml | 2 +- .github/workflows/release.yml | 4 ++-- pyproject.toml | 7 +++---- .../integration/docker-compose.localstack.yml | 2 +- 6 files changed, 16 insertions(+), 30 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b7314d0..d422b280 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,7 +25,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/setup-python-environment.yml with: @@ -38,7 +38,7 @@ jobs: strategy: matrix: os: [windows-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/setup-python-environment.yml with: @@ -51,7 +51,7 @@ jobs: strategy: matrix: os: [macos-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/setup-python-environment.yml with: @@ -64,7 +64,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/lint-unit-test.yml with: @@ -77,7 +77,7 @@ jobs: strategy: matrix: os: [windows-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/lint-unit-test.yml with: @@ -90,7 +90,7 @@ jobs: strategy: matrix: os: [macos-latest] - python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12"] fail-fast: false uses: ./.github/workflows/lint-unit-test.yml with: diff --git a/.github/workflows/lint-unit-test.yml b/.github/workflows/lint-unit-test.yml index 11e9f5a5..017ff37d 100644 --- a/.github/workflows/lint-unit-test.yml +++ b/.github/workflows/lint-unit-test.yml @@ -32,13 +32,12 @@ on: description: 'Python version' type: choice options: - - '3.8' - '3.9' - '3.10' - '3.11' - '3.12' required: false - default: '3.8' + default: '3.9' enable_tmate: description: 'Enable tmate session for debugging' type: choice @@ -86,20 +85,8 @@ jobs: - name: Docstring check run: bash scripts/docstring.sh - # Only run the docstring check on ubuntu-latest and python 3.8 - if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.8' }} - - # - name: Markdown link check - # uses: gaurav-nelson/github-action-markdown-link-check@v1 - # with: - # use-quiet-mode: 'yes' - # use-verbose-mode: 'no' - # folder-path: './examples, ./docs/book, ./src' - # file-path: './README.md, ./LICENSE, ./RELEASE_NOTES.md, CODE-OF-CONDUCT.md, CONTRIBUTING.md, CLA.md, RELEASE_NOTES.md, ROADMAP.md' - # config-file: .github/workflows/markdown_check_config.json - # continue-on-error: true - # # Only run the markdown link check on ubuntu-latest and python 3.8 - # if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.8' }} + # Only run the docstring check on ubuntu-latest and python 3.9 + if: ${{ inputs.os == 'ubuntu-latest' && inputs.python-version == '3.9' }} - name: Run unit tests run: | diff --git a/.github/workflows/publish-pypi-package.yml b/.github/workflows/publish-pypi-package.yml index acf7cb89..24c684be 100644 --- a/.github/workflows/publish-pypi-package.yml +++ b/.github/workflows/publish-pypi-package.yml @@ -22,7 +22,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5.0.0 with: - python-version: "3.8" + python-version: "3.9" - name: Install Poetry uses: snok/install-poetry@v1.3.4 with: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b23fb33b..73b46a04 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: uses: ./.github/workflows/lint-unit-test.yml with: os: "ubuntu-latest" - python-version: "3.8" + python-version: "3.9" secrets: inherit # checks zenml and mlstacks can be installed together in same environment @@ -25,7 +25,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v2 with: - python-version: "3.8" + python-version: "3.9" - name: Install current package as editable run: pip install -e . diff --git a/pyproject.toml b/pyproject.toml index 7b52cea8..12b97d1b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -21,7 +21,6 @@ classifiers = [ "Intended Audience :: System Administrators", "License :: OSI Approved :: Apache Software License", "Programming Language :: Python :: 3 :: Only", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", @@ -64,7 +63,7 @@ exclude = [ ] [tool.poetry.dependencies] -python = ">=3.8,<3.13" +python = ">=3.9,<3.13" pydantic = { version = "~2.8" } pyyaml = { version = ">=6.0.1" } click = { version = "^8.0.1,<8.1.4" } @@ -164,8 +163,8 @@ select = [ ignore = ["COM812", "ISC001"] src = ["src", "tests"] -# use Python 3.8 as the minimum version for autofixing -target-version = "py38" +# use Python 3.9 as the minimum version for autofixing +target-version = "py39" ignore-init-module-imports = true # # Disable autofix for unused imports (`F401`). # unfixable = ["F401"] diff --git a/tests/integration/docker-compose.localstack.yml b/tests/integration/docker-compose.localstack.yml index 6e97d7f2..3521f9f1 100644 --- a/tests/integration/docker-compose.localstack.yml +++ b/tests/integration/docker-compose.localstack.yml @@ -1,4 +1,4 @@ -version: "3.8" +version: "3.9" services: localstack: