feat: "in memory" behavior #590
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
feat/in-memory-behavior
branch
from
3e88d34
to
f7be7ac
Compare
nikophil
force-pushed
the
feat/in-memory-behavior
branch
3 times, most recently
from
4add46a
to
57bbc01
Compare
nikophil
commented
May 1, 2024
nikophil
force-pushed
the
feat/in-memory-behavior
branch
2 times, most recently
from
f6684d2
to
7914ee1
Compare
nikophil
force-pushed
the
feat/in-memory-behavior
branch
2 times, most recently
from
23b2122
to
51dac5b
Compare
nikophil
force-pushed
the
feat/in-memory-behavior
branch
from
51dac5b
to
4b3c8e2
Compare
nikophil
commented
Aug 18, 2024
src/Configuration.php
Outdated
Comment on lines
114
to
134
| public function enableInMemory(): void | ||
| { | ||
| $this->inMemory = true; | ||
| } | ||
|
|
||
| public function isInMemoryEnabled(): bool | ||
| { | ||
| return $this->inMemory; | ||
| } |
There was a problem hiding this comment.
At first, I did something like:
Configuration::instance()->persistence()->enableInMemory();and the $inMemory boolean was stored in PersistenceManager. But then, all InMemoryTest did not worked when no persistence is activated, which is a non-sense 🤷
Then I decided to store this in the Configuration class
nikophil
force-pushed
the
feat/in-memory-behavior
branch
12 times, most recently
from
56a501b
to
558fc5f
Compare
smnandre
reviewed
Aug 31, 2024
nikophil
force-pushed
the
feat/in-memory-behavior
branch
3 times, most recently
from
5e8a734
to
90502f7
Compare
nikophil
force-pushed
the
feat/in-memory-behavior
branch
from
90502f7
to
7608b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces "in-memory" behavior
fixes #533
NB: In a follow up PR, I'll introduce
InMemoryRepositoryDecorator, so it will be easier to make assertions