Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF8 BOM Seems to be Missing from UTF8BOM Test #3387

Open
InsertCreativityHere opened this issue Jan 20, 2025 · 0 comments
Open

UTF8 BOM Seems to be Missing from UTF8BOM Test #3387

InsertCreativityHere opened this issue Jan 20, 2025 · 0 comments
Milestone

Comments

@InsertCreativityHere
Copy link
Member

We have a test to ensure that the Slice compilers can correctly tolerate the presence of Byte-Order-Markers in Slice files,
https://github.com/zeroc-ice/ice/blob/main/cpp/test/Slice/utf8BOM/Test.ice

But, opening this file up in a hex-editor, there is no BOM at the beginning of the file.
I guess it was deleted by an auto-formatter or one of the times we changed the copyright headers.

We should add the BOM back, and change the test so it fails if the BOM was deleted somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant