Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the protocol version is upgraded to 3.1? #79

Open
myzhan opened this issue Nov 4, 2020 · 2 comments
Open

Why the protocol version is upgraded to 3.1? #79

myzhan opened this issue Nov 4, 2020 · 2 comments

Comments

@myzhan
Copy link
Contributor

myzhan commented Nov 4, 2020

It seems that the protocol version is upgraded to 3.1 for no reason in this PR.

https://github.com/zeromq/gomq/pull/77/files

In the rfc of zeromq, "Resource" is added to connnection metadata in version 3.1. But this PR has nothing to do with "Resource".
@myzhan myzhan mentioned this issue Nov 4, 2020
Closed
@franzramadhan
Copy link

franzramadhan commented Nov 18, 2020 •
edited
Loading

what is the impact if the version reverted back to 3.0 ?

@myzhan
Copy link
Contributor Author

myzhan commented Nov 18, 2020

@franzramadhan I use gomq to connect to a pyzmq server. if the version is updated to 3.1, handshake will fail, becase the server sends 3.0 greeting message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myzhan @franzramadhan