Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple failing unit tests #959

Open
jasells opened this issue Dec 31, 2020 · 1 comment · May be fixed by #960
Open

Multiple failing unit tests #959

jasells opened this issue Dec 31, 2020 · 1 comment · May be fixed by #960
Labels

Comments

@jasells
Copy link

jasells commented Dec 31, 2020

Environment

NetMQ Version:    latest master branch (debug)
Operating System: Win10
.NET Version:     all

Expected behaviour

Unit tests run and pass

Actual behaviour

Many tests fail

Steps to reproduce the behaviour

Run unit tests.

Is this expected on the current master branch?

**update: it does appear to only occur for debug build, so I assume that unit tests are not typically run in debug. The root of most of the failures seem to be the Assumes.NotNull() helper for asserts being misplaced. So, though it is not failing on release builds, it is possibly not executing as expected.

Example: NetMqPollerTest.RemoveSocket() hits M-handle null check before it is ever created:

public virtual void SetAddress(string addr)
        {
            m_address.Resolve(addr, m_options.IPv4Only);

            Assumes.NotNull(m_address.Address);
            Assumes.NotNull(m_handle);

            try
            {
                m_handle = AsyncSocket.Create(m_address.Address.AddressFamily, SocketType.Stream, ProtocolType.Tcp);

Src link.

@jasells jasells linked a pull request Dec 31, 2020 that will close this issue
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.

@stale stale bot added the stale label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant