-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib prefix on Windows #942
Comments
I think one issue is backward compatibility - if the filename changes, there's a good chance all existing projects that use it will break |
Well, the breakage mode needs that a project is regenerated. And users should review (git diff) or PR (and web-review) the changes. Also GSL can Another breakage may be that projects which use your component (say mlm.dll as deliverable) can get broken by your upgrade and might have to rebuild. Or... as a legacy fallback you might add a rule (simple Sent from my Xiaomi Redmi Note 4 using FastHub |
Yeah the problem is external reverse dependencies, that do not use zproject. Having a backward compatibility link could work as a solution |
About prefix I'm not sure but it seems that CMake don't put the prefix with MSVC not with MSYS or MINGW. It seems that nobody try the mlm/czmq python binding with MSVC toolchain. |
Is there any convention related to lib prefix for zproject on Windows.
Because by default in cmake for a library target called mlm on Windows the output file is mlm.dll and on linux it's libmlm.so
The issue is that project.libname is always prefixed by lib
project.libname is defined here
zproject/zproject.gsl
Line 51 in de9a672
project.libname is used in python binding for finding the library
Shouldn't we use something like that?
The text was updated successfully, but these errors were encountered: