Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support non-zero-terminated strings (pointer+size, i.e. std::string_view) #495

Closed
Hedede opened this issue May 10, 2022 · 1 comment
Closed

Comments

@Hedede
Copy link

Hedede commented May 10, 2022

I use std::string_view extensively in my code, because it allows to make substrings very cheaply (requires only adjusting a couple of pointers instead of copying the string), but pugixml accepts only const char* arguments, which forces me to make local copies of strings.

It would nice to have either a std::string_view overload, or const char*, size_t overload.

@rettinghaus
Copy link

See #73

@zeux zeux added the duplicate label Sep 10, 2022
@zeux zeux closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants