Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nix binary cache to for ZLS #2034

Closed
ethanholz opened this issue Sep 18, 2024 · 3 comments
Closed

Add a nix binary cache to for ZLS #2034

ethanholz opened this issue Sep 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ethanholz
Copy link

Is there any way that we could potentially get a binary cache for the Nix build of ZLS? This would make installation much faster for those using Nix. From a CI perspective, this would require the setup of an action to install Nix, build ZLS, and then cache the derivations into something like cachix.

@ethanholz ethanholz added the enhancement New feature or request label Sep 18, 2024
@Techatrix
Copy link
Member

AFAIKT Cachix is unlikely to happen. ZLS provides prebuilt binaries (See https://github.com/zigtools/release-worker/) that need to be accessibly to non Nix users as well. Something similar to https://github.com/mitchellh/zig-overlay can be done to provide these binaries to Nix users.

On the topic of installation time for Nix, the checkPhase could be skipped to save some time running the tests.

@ethanholz
Copy link
Author

Doing something like https://github.com/mitchellh/zig-overlay was what I was going to attempt if an official binary cache is not an option. Thanks for the response and I will dig into using the prebuilt binaries!

@mocompute
Copy link

@ethanholz If you do such a thing, please share. I also had to disable checkPhase recently because of some error that kept occurring. And there's always a FileNotFound during build, but I haven't investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants