-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ฅโจ Marketplace
: Buying ๐ฅก Products
#1326
Labels
โจ feature
Reduces Client's Burden or Grants them Benefits
๐ฅ Satisfices
It's good enough to use, but not particularly great
Comments
zspencer
added
โจ feature
Reduces Client's Burden or Grants them Benefits
๐ฅ Satisfices
It's good enough to use, but not particularly great
labels
Apr 8, 2023
zspencer
changed the title
๐ฅ
โจ๐ฅ Apr 8, 2023
Marketplace
: Buying Product
sMarketplace
: Buying Product
s
zspencer
changed the title
โจ๐ฅ
๐ฅโจ Apr 8, 2023
Marketplace
: Buying Product
sMarketplace
: Buying Product
s
zspencer
added a commit
that referenced
this issue
Apr 9, 2023
โฆent` - #1325 - #1324 - #1326 I didn't use the `marketplace_order, :full` factory outside of the `Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and apparently had flubbed the implementation; so that was not working... So I fixed it and used it in the `Order::EmailReceiptComponent` spec to test the `Order#delivery_area` I also noticed we didn't wire in associations between the `Marketplace::DeliveryArea` into the `Marketplace::Cart` and `Marketplace::Order` so I added some specs for those.
zspencer
added a commit
that referenced
this issue
Apr 9, 2023
โฆent` - #1325 - #1324 - #1326 I didn't use the `marketplace_order, :full` factory outside of the `Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and apparently had flubbed the implementation; so that was not working... So I fixed it and used it in the `Order::EmailReceiptComponent` spec to test the `Order#delivery_area` I also noticed we didn't wire in associations between the `Marketplace::DeliveryArea` into the `Marketplace::Cart` and `Marketplace::Order` so I added some specs for those.
zspencer
added a commit
that referenced
this issue
Apr 9, 2023
โฆent` (#1332) - #1325 - #1324 - #1326 I didn't use the `marketplace_order, :full` factory outside of the `Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and apparently had flubbed the implementation; so that was not working... So I fixed it and used it in the `Order::EmailReceiptComponent` spec to test the `Order#delivery_area` I also noticed we didn't wire in associations between the `Marketplace::DeliveryArea` into the `Marketplace::Cart` and `Marketplace::Order` so I added some specs for those.
zspencer
added a commit
that referenced
this issue
Apr 9, 2023
- #1326 - #1187 - ๐ ๏ธ `Components`: Makes sure Tailwind notices `Furniture`'s `Component` files - ๐งน `Components` I'm not sure if this is the right path or not but it decouples our `ButtonComponent` from the `button.scss` file, and makes it a bit easier to override the defaults for how we present buttons. - ๐ธ Gets rid of the extra `Marketplace::Cart::Delivery::EditButtonComponent` that hangs out underneath the cart - ๐ธ Tailors the `Marketplace::Cart::Delivery::EditButtonComponent` better for smaller screens.
zspencer
added a commit
that referenced
this issue
Apr 9, 2023
- #1326 - #1187 - ๐ ๏ธ `Components`: Makes sure Tailwind notices `Furniture`'s `Component` files - ๐งน `Components` I'm not sure if this is the right path or not but it decouples our `ButtonComponent` from the `button.scss` file, and makes it a bit easier to override the defaults for how we present buttons. - ๐ธ Gets rid of the extra `Marketplace::Cart::Delivery::EditButtonComponent` that hangs out underneath the cart - ๐ธ Tailors the `Marketplace::Cart::Delivery::EditButtonComponent` better for smaller screens.
zspencer
added a commit
that referenced
this issue
Apr 10, 2023
- #1326 - #1187 - ๐ ๏ธ `Components`: Makes sure Tailwind notices `Furniture`'s `Component` files - ๐งน `Components` I'm not sure if this is the right path or not but it decouples our `ButtonComponent` from the `button.scss` file, and makes it a bit easier to override the defaults for how we present buttons. - ๐ธ Gets rid of the extra `Marketplace::Cart::Delivery::EditButtonComponent` that hangs out underneath the cart - ๐ธ Tailors the `Marketplace::Cart::Delivery::EditButtonComponent` better for smaller screens.
zspencer
added a commit
that referenced
this issue
Apr 10, 2023
* ๐ธ๐ ๏ธ๐งน `Marketplace`: Tidy up `Marketplace#show` - #1326 - #1187 - ๐ ๏ธ `Components`: Makes sure Tailwind notices `Furniture`'s `Component` files - ๐งน `Components` I'm not sure if this is the right path or not but it decouples our `ButtonComponent` from the `button.scss` file, and makes it a bit easier to override the defaults for how we present buttons. - ๐ธ Gets rid of the extra `Marketplace::Cart::Delivery::EditButtonComponent` that hangs out underneath the cart - ๐ธ Tailors the `Marketplace::Cart::Delivery::EditButtonComponent` better for smaller screens. * ๐งน`Components`: Consolidate `margin` and `padding` as `spacing` Again, not sure this is a great idea but I wanted some way to partially overload the default classes a component uses.
zspencer
added a commit
that referenced
this issue
Apr 20, 2023
This was referenced Apr 20, 2023
zspencer
added a commit
that referenced
this issue
Apr 20, 2023
zspencer
added a commit
that referenced
this issue
Apr 20, 2023
zspencer
added a commit
that referenced
this issue
May 4, 2023
- #1326 - #1324 This is wildly insufficient, but it gets us to the point where we're able to test that the way we're calling `Stripe::Checkout::Session.create` is at least *close* to what it's supposed to be called with. It would be far better to get a `spec/furniture/marketplace/system` that actually hits Stripe...
zspencer
added a commit
that referenced
this issue
May 4, 2023
`Marketplace`: Get a test on the `Checkout` - #1326 - #1324 This is wildly insufficient, but it gets us to the point where we're able to test that the way we're calling `Stripe::Checkout::Session.create` is at least *close* to what it's supposed to be called with. It would be far better to get a `spec/furniture/marketplace/system` that actually hits Stripe...
zspencer
added a commit
that referenced
this issue
Jan 14, 2024
zspencer
added a commit
that referenced
this issue
Jan 14, 2024
- #2043 - #1326 While we definitely need a `Cart`; treating the `Cart` as the `Menu` is a clunky ducky way of operating. I'm going to start driving towards a more `Menu` centric approach so the Shopping experience looks and feels a bit less nerd-forward. Theoretically, this will entail: - [ ] Sprouting `Product#show` - [ ] Ditching the `Marketplace::Cart` ui almost completely, perhaps? - [ ] Updating `buying_products_system_spec.rb`
zspencer
added a commit
that referenced
this issue
Jan 14, 2024
- #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective.
zspencer
added a commit
that referenced
this issue
Jan 15, 2024
- #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective.
zspencer
added a commit
that referenced
this issue
Jan 21, 2024
- #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective.
zspencer
added a commit
that referenced
this issue
Jan 25, 2024
- #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective.
zspencer
added a commit
that referenced
this issue
Jan 25, 2024
- #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective.
zspencer
added a commit
that referenced
this issue
Jan 25, 2024
โฆesolution (#2115) - #1326 The aspect ratio is now 16x9, which should be easier for people to just "naturally" upload. The width of the small hero variant is edge-to-edge full-def on Apple's current highest-end device, the iPhone 15 Pro Max. There's probably a way smarter way of doing this that uses say, background images and CSS selectors to load just-the-right-sized image for the particular use-case; but I figure going big-and-downscaling is probably better from a "make pretty" perspective. * Just a smidge of space
zspencer
added a commit
that referenced
this issue
Jan 29, 2024
โฆ2072) - #2153 - #1326 * ๐ธ `Marketplace`: Distinguish the `Cart` from the `Menu` - #2043 - #1326 While we definitely need a `Cart`; treating the `Cart` as the `Menu` is a clunky ducky way of operating. * ๐งน `Marketplace`: Drop the overly ambitious `Products#show` work Getting the `Menu` to a good place is the more important move here; we can add a `Products#show` endpoint ๐ rather than :now: * ๐ธ `Marketplace`: Order `Products` in `Cart` by time added I always forget that if you don't explicitely include an `order` Postgresql will return things based upon... well, how it feels in the moment. This ensures the `Cart` always shows it's `Products` in the order they were added to the `Cart`; so that they don't randomly swap around when changing quantity. * ๐ธ `Marketplace`: `Product` on the `Menu` looks consistent with `Products#index` The `Products#index` is really only available to a `Space` `Member` at the moment; but it is what `People` adding `Products` to the `Marketplace` see; so it makes sense that the `Menu` look the same * ๐ธ `Marketplace`: `Menu` has a prettier Add to Cart button - #2153 The `Add to Cart` button is wide and looks nice!
This was referenced Feb 10, 2024
Closed
zspencer
changed the title
๐ฅโจ
๐ฅโจ Feb 17, 2024
Marketplace
: Buying Product
sMarketplace
: ๐ฅก Buying Products
zspencer
changed the title
๐ฅโจ
๐ฅโจ Feb 17, 2024
Marketplace
: ๐ฅก Buying Products
Marketplace
: Buying ๐ฅก Products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
โจ feature
Reduces Client's Burden or Grants them Benefits
๐ฅ Satisfices
It's good enough to use, but not particularly great
Gizmo
:Marketplace
ย #831Use Cases
When ๐ฅโจ
Marketplace
: Buying ๐ฅกProducts
ย #1326 a ๐บMarketplace
:Shopper
ย #2043 moves through four stages:Marketplace
:Order
ย #2215 including finding a ๐ง๐ฝโ๐ณMarketplace
:Vendor
ย #2044 and setting their ๐บ๏ธMarketplace
:DeliveryArea
ย #1136Marketplace
:Order
ย #2215 by browsing the ๐Marketplace
:Menu
ย #2153 and adds ๐ฅกMarketplace
:Product
ย #2169(s) to their ๐Marketplace
:Cart
ย #2155.Marketplace
:Cart
ย #2155, confirming their ๐บ๏ธMarketplace
:DeliveryArea
ย #1136 andMarketplace
:Order#delivery_address
ย #1763, and making a Payment to finalize their ๐๏ธMarketplace
:Order
ย #2215Marketplace
:Delivery
ย #1325 for their ๐๏ธMarketplace
:Order
ย #2215๐ฅ Preparing to Buy
Marketplace
: Finding aProduct
toOrder
ย #2378Marketplace
:Menu
ย #2153Marketplace
:Cart
ย #2155Product
s toCart
Product
quantities inCart
Product
s fromCart
Delivery
details๐ฅ
Marketplace
: ๐บShopper
Checks Out ๐Cart
Marketplace
- Improve the checkout experienceย #1672๐ฅ Paying for
Order
Order
Marketplace
: Pay with EBT & SNAPย #1238Client
: Piikupย #832Client
: Piikupย #832Client
: Piikupย #832Domain Model
Marketplace
:Product
ย #2169Marketplace
:Menu
ย #2153Marketplace
:Cart
ย #2155Marketplace
:Order
ย #2215Bugs
Marketplace
:Buying Products:
Guestis shown a 404 after
Checkout`ย #1657Marketplace
:Buying Products
: SavingDelivery Details
onCheckout
when noCart Delivery Area
is setย #1983Marketplace
:Buying Products
: ChangingDeliveryArea
does not update theCart
DeliveryFee
ย #2002Marketplace
:Buying Products
: SwitchingMarketplaces
should not destroy yourCart
ย #1962Marketplace
:Buying Products
- Can'tCheckout
when only one unarchivedDeliveryArea
ย #2198The text was updated successfully, but these errors were encountered: