-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🥡 Marketplace
: Product#servings
#2170
Comments
This was referenced Feb 1, 2024
zspencer
added a commit
that referenced
this issue
Feb 1, 2024
- #2170 We can get the Products serving size and show them to the user
zspencer
added a commit
that referenced
this issue
Feb 1, 2024
- #2170 We can get the Products serving size and show them to the user
zspencer
added a commit
that referenced
this issue
Feb 3, 2024
* 🥗 `Marketplace`: Test Listing `Products` - #2168 It may be nice to get rid of the `Rspec/ExampleLength` cop, because omg it doesn't make sense to apply it in the case of system specs. But I also don't know enough about how to do that effortlessly, and I am too lazy to put in the effort right now. Also apparently we may be able to get rid of the `chomp`! Apparently ```rb <<~THING.gsub("\n", " ") Should wind up as having no line breaks THING ``` Also, it would be nice if `within(created_product)` did the same thing as `within("##{dom_id(created_product)}")` since that looks horrifying. Maybe `visit(object)` could do something similar with polymorphic path? Co-Authored-By: Tim Taylor <[email protected]> * 🧹 We don't need that `chomp`! Co-authored-by: [email protected] * 🥗✨ `Marketplace`: Add `Product#servings` - #2170 We can get the Products serving size and show them to the user * 🧹 `Marketplace`: Extract `Product::TitleComponent` I don't know how useful this is, but I did notice that we were doing the same thing 4 times and wanted to put it in a place of it's own. --------- Co-authored-by: Tim Taylor <[email protected]>
zspencer
added a commit
that referenced
this issue
Feb 17, 2024
zspencer
added a commit
that referenced
this issue
Feb 22, 2024
zspencer
added a commit
to zinc-collective/tobias
that referenced
this issue
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Marketplace
:Product#servings
#2170 so 🕺Marketplace
:Shopper
#2043 can make informed choices about how far their $$$ will go on a per 🥡Marketplace
:Product
#2169 basis.The text was updated successfully, but these errors were encountered: