Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gap missing on pages #2271

Open
rosschapman opened this issue Mar 2, 2024 · 0 comments
Open

Gap missing on pages #2271

rosschapman opened this issue Mar 2, 2024 · 0 comments
Labels
🐞 bug Something isn't working 🌸 Polish Improves the UX! 🌱 Ready for Dev Stuff we are able to move forward on

Comments

@rosschapman
Copy link
Contributor

rosschapman commented Mar 2, 2024 •
edited
Loading

Some layouts are squished against the viewport edge. I found at least a couple examples:

New Entry

image

Account

image
@rosschapman rosschapman added 🐞 bug Something isn't working 🌱 Ready for Dev Stuff we are able to move forward on 🌸 Polish Improves the UX! labels Mar 2, 2024
zspencer added a commit that referenced this issue Mar 7, 2024
@zspencer
🌸 DesignLibrary: Layout is responsible for.... Layout...
515c686 
- #1187
- #2271
- #2253

One of the things we've kept bumping into is that each page has to
decide how wide it wants to be. That doesn't really seem sustainable or
particularly necessary; so now the Layout takes care of:

- Providing a Max-Width on every page
- Ensuring the Layout is centered horizontally
- Ensuring there is appropriate margin from the top
  of the screen
@zspencer zspencer mentioned this issue Mar 7, 2024
Merged
zspencer added a commit that referenced this issue Mar 7, 2024
@zspencer
🌸 DesignLibrary: Layout is responsible for.... Layout... (#2281)
7e24542 
- #1187
- #2271
- #2253

One of the things we've kept bumping into is that each page has to
decide how wide it wants to be. That doesn't really seem sustainable or
particularly necessary; so now the Layout takes care of:

- Providing a Max-Width on every page
- Ensuring the Layout is centered horizontally
- Ensuring there is appropriate margin from the top
  of the screen
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
@zspencer
🌸 DesignLibrary: Layout is responsible for.... Layout... (zinc-coll…
a92e7f9 
…ective#2281)

- zinc-collective#1187
- zinc-collective#2271
- zinc-collective#2253

One of the things we've kept bumping into is that each page has to
decide how wide it wants to be. That doesn't really seem sustainable or
particularly necessary; so now the Layout takes care of:

- Providing a Max-Width on every page
- Ensuring the Layout is centered horizontally
- Ensuring there is appropriate margin from the top
  of the screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 🌸 Polish Improves the UX! 🌱 Ready for Dev Stuff we are able to move forward on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rosschapman