[General] Sending type 113 transactions is failing in foundry

[PatrickAlphaC]

Environment

Testnet

Provide a brief description of the functionality you're trying to implement.

I am working on creating some sample native account abstraction accounts in foundry to compare the EVM's edition against zkSync's, and I'm running into an issue.

The error I'm getting looks like such:

  [23992] ZkMinimalAccountTest::testZkNonOwnerCanExecuteCommand()
    ├─ [0] VM::sign("<pk>", 0xf11d3284929b91cda6e4ef14faf04af456a95f5d97ed5a2ab1dbbbca92757912) [staticcall]
    │   └─ ← 28, 0x7a2dcabd2980276d9c7448b0243101acff8755fbe1db6580f2a022c51cf0fbdf, 0x12d021df27f58d3f74d285c023d5bb0e4032909e989575c9f4eedf3fcae83e49
    ├─ [0] VM::prank(randomUser: [0xc7be087fF5E8811dcED44BB1a098832Ea3663dE8])
    │   └─ ← ()
    ├─ [0] 0xd6A7A38ee698eFae2F48F3a62dC7a71C3C0930A1::executeTransactionFromOutside(Transaction({ txType: 113, from: 620291210606903491219610452665372689947276415645 [6.202e47], to: 1426751032505596172244636458211064681691227589168 [1.426e48], gasLimit: 16777216 [1.677e7], gasPerPubdataByteLimit: 16777216 [1.677e7], maxFeePerGas: 16777216 [1.677e7], maxPriorityFeePerGas: 16777216 [1.677e7], paymaster: 0, nonce: 0, value: 0, reserved: [0, 0, 0, 0], data: 0x1249c58b, signature: 0x7a2dcabd2980276d9c7448b0243101acff8755fbe1db6580f2a022c51cf0fbdf12d021df27f58d3f74d285c023d5bb0e4032909e989575c9f4eedf3fcae83e491c, factoryDeps: [], paymasterInput: 0x, reservedDynamic: 0x }))
    │   └─ ← EvmError: Revert
    └─ ← EvmError: Revert

It's a bit cryptic, EvmError is the classic "whoops, something bad happened, but the current state of debugging tools is really rough to get to the bottom of the issue". I'm not sure if it's clear to someone here based on the Transaction what the problem is. Here is how it's being generated:

    function testZkNonOwnerCanExecuteCommand() public {
        // Arrange
        address dest = address(mockERC20);
        uint256 value = 0;
        bytes memory func = abi.encodeWithSelector(MockERC20.mint.selector);

        Transaction memory transaction = _getUnsignedTransaction(user, ZKSYNC_AA_TX_TYPE, dest, value, func);
        transaction = _signTransaction(transaction, userKey);

        // Act
        vm.prank(randomUser);
        minimalAccount.executeTransactionFromOutside(transaction);

        // Assert
        assertEq(mockERC20.balanceOf(address(minimalAccount)), mockERC20.AMOUNT());
    }

function _getUnsignedTransaction(
        address from,
        uint8 transactionType,
        address to,
        uint256 value,
        bytes memory data
    )
        internal
        pure
        returns (Transaction memory)
    {
        bytes32[] memory emptyArray = new bytes32[](0);

        return Transaction({
            txType: transactionType,
            from: uint256(uint160(from)),
            to: uint256(uint160(to)),
            gasLimit: 1 << 24,
            gasPerPubdataByteLimit: 1 << 24,
            maxFeePerGas: 1 << 24,
            maxPriorityFeePerGas: 1 << 24,
            paymaster: 0,
            nonce: 0, // hard coded for 0 for now
            value: value,
            reserved: [uint256(0), uint256(0), uint256(0), uint256(0)],
            data: data,
            signature: hex"",
            factoryDeps: emptyArray,
            paymasterInput: hex"",
            reservedDynamic: hex""
        });
    }

    function _signTransaction(
        Transaction memory transaction,
        uint256 privateKey
    )
        public
        view
        returns (Transaction memory)
    {
        // This method returns the hash of the struct WITHOUT the signature.
        bytes32 unsignedTransactionHash = MemoryTransactionHelper.encodeHash(transaction);
        // I have no idea if this is correct to do this
        bytes32 digest = unsignedTransactionHash.toEthSignedMessageHash();
        (uint8 v, bytes32 r, bytes32 s) = vm.sign(privateKey, digest);
        Transaction memory signedTransaction = transaction;
        signedTransaction.signature = abi.encodePacked(r, s, v); // Note the order!
        return signedTransaction;
    }

I know this is a bit of a "debug me" question, but it would seem this should work? And if not, I'd get a revert error from the zkSync contracts?

I'm running the test like so:

forge test --zksync --via-ir --mt testZkNonOwnerCanExecuteCommand

What is the specific issue or error you're encountering?

see above

Can you share the error messages or logs you're receiving, if any?

see above

Have you made any recent changes to the contract before encountering this issue?

see above

Are there any external libraries or contracts that your contract interacts with?

see above

Can you provide the relevant portions of your contract code where the issue is occurring?

see above

Have you tried to isolate the problem, and if so, what were the results?

see above

What steps have you already taken to try to resolve the issue?

see above

Repo Link (Optional)

No response

Additional Details

No response

[dutterbutter]

@PatrickAlphaC thanks for posting!

I will need to investigate this but one thing that will be required if you haven't included it is to make use of the is-system flag either in the command line or included in the foundry.toml file.

[WillStansill]

I am currently dealing with this same problem so if you ever found a solution to this I would love to hear it

[bxpana]

@WillStansill you're getting the EvmError when trying to execute a txn or are you getting it somewhere else? If there is anything different about your issue, the more details the better