Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huggingface integration #181

Open
ivelin opened this issue Apr 4, 2023 · 7 comments
Open

Huggingface integration #181

ivelin opened this issue Apr 4, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@ivelin
Copy link

ivelin commented Apr 4, 2023

This maybe a very big stretch goal given current model size and ops limitations, but inspirationally worth considering.
Could be a big unlock of applications on ezkl, if it is simple enough for app devs to to plug ezkl into the huggingface transformer APIs and demo spaces.

@jasonmorton
Copy link
Member

This is a great idea! What kind of integration are you looking for? Maybe we could do some automatic downloading and conversion of models based on their huggingface identifiers?

@ivelin
Copy link
Author

ivelin commented Apr 5, 2023

For example being able to inject ezkl step in an inference pipeline that outputs a proof that huggingface model XYZ located at repo "mymodels/xyz" with git revision "abcd" and corresponding hash "efgh" ran on some private data input and produced public output "ijk".

A specific use case that comes to mind is being able to run a fine tuned DocVQA model on utility bills for KYC verification. Confirm that the secret input PDF is a valid (non-fake) recent utility bill from a US based zip code and belongs to Bob Hackman.

@jasonmorton
Copy link
Member

That makes sense. @JSeam2 is working on some of the prerequisites for this.

@JSeam2
Copy link
Collaborator

JSeam2 commented Apr 5, 2023

One possibility right now is to manually extract the onnx files and obtain the outputs from the hugging face models. The challenge is that the compute requirements for huggingface models might require a distributed setup to run.

If the model is small enough, a work around is to use python subprocess to run ezkl and use the built ezkl program within python, however, it's still fairly clunky. I used that approach for a hackathon and created a python server for a similar purpose. I have written some code regarding the subprocess approach that could be useful for you. https://github.com/JSeam2/zkml-server/blob/main/app.py

At the moment I'm still working on bindings with pyo3 on a fork of ezkl https://github.com/jseam2/ezkl/tree/python. When this is ready for production the goal is to merge the changes into the main repo and expose the bindings to the pyezkl repo which would offer more expressivity within python. The rust bindings are limited to pep387 compatibility so the feature set used for the rust bindings would be minimal.

@rmlearney-digicatapult
Copy link

rmlearney-digicatapult commented Aug 1, 2024

Hi @JSeam2, could I extend the comment by @ivelin and ask if it's possible to embed metadata into the compiled ezkl such as the points he suggested or arbitrary length cryptographic commitments to e.g. training dataset?

@jasonmorton
Copy link
Member

@rmlearney-digicatapult that's a very interesting idea. We could add a metadata field like this and leave it to the user to decide how to use it initially.

@rmlearney-digicatapult
Copy link

🙏🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants