Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a type definition to the package #568

Open
mh-alahdadian opened this issue May 31, 2019 · 5 comments
Open

add a type definition to the package #568

mh-alahdadian opened this issue May 31, 2019 · 5 comments

Comments

@mh-alahdadian
Copy link

hello

I know that there is already a typescript type definition for this package in @types/core-js but many packages are trying to make a type definition inside of they're packages which has benefits like always sync to the package version and doesn't need to install it separately

can you add a type definition into this repo ? and I'm interested to do it if you want

@nicolo-ribaudo
Copy link
Contributor

Since core-js matches the JavaScript API, doesn't TypeScript support them out of the box?

@mh-alahdadian
Copy link
Author

it doesn't match completely , it have some proposal functions that not in the typescript lib, and also some interfaces like Dict which are not in pure js

@zloirock
Copy link
Owner

zloirock commented Jun 1, 2019

@nicolo-ribaudo you're right, but only about stable JS and global polyfills. core-js contains also polyfills for early-stage proposals which haven't any standard type definitions and entry points for the version without global pollution. Type definitions for them could be useful.

@mha15 Dict and other non-standard features removed from core-js@3.

Feel free to add a PR.

@zloirock
Copy link
Owner

zloirock commented Aug 5, 2022

https://github.com/Kingwl/core-dts

@zloirock
Copy link
Owner

Type definitions for core-js-builder added in 3.28.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants