Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test scripts/sample images #24

Open
zoellner opened this issue Oct 30, 2023 · 0 comments
Open

Add test scripts/sample images #24

zoellner opened this issue Oct 30, 2023 · 0 comments

Comments

@zoellner
Copy link
Owner

zoellner commented Oct 30, 2023

In order to streamline further development, we should add a few tests that prevent the layer build from succeeding while the Lambda execution later fails.

The tests should cover a few simple conversion to and narrow down any future build issues.

  • sample heic file to jpg via command line. That would allow to test the libvips library separately
  • sample jpeg file to webp via command line
  • same two tests but within sharp

This would also help with local development using a docker container and avoid having to push WIP code to the repo in order to have it build on CodeBuild. A final test before tagging a release is still necessary since there are always some subtle differences between local testing and the CodeBuild and Lambda environments.

The test data should not end up in the final lambda layer.

Edit: After some testing I found that the examples in libheif (convert-heic) and the vips command line tool in libvips work fine and already include sample images to use.
However, the final sharp/lambda layer still doesn't work, so the focus should really be on the last bullet point above testing the libraries through sharp.

@zoellner zoellner added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant