Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for storage transformers. #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for storage transformers. #26

wants to merge 1 commit into from

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 9, 2024

closes #24

@zoj613 zoj613 added enhancement New feature or request metadata relating to metadata transformers relating to storage transformers labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (aa31327) to head (dc2e1bf).

Files Patch % Lines
lib/extensions.ml 32.00% 17 Missing ⚠️
lib/metadata.ml 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.82%   93.26%   -1.57%     
==========================================
  Files          13       13              
  Lines        1082     1113      +31     
==========================================
+ Hits         1026     1038      +12     
- Misses         56       75      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 force-pushed the transformers branch 2 times, most recently from 510222b to 7d0b71c Compare July 9, 2024 19:51
@zoj613
Copy link
Owner Author

zoj613 commented Jul 9, 2024

@d-v-b, Are there any storage transformers being used in practice for Zarr v3? The spec doesn't define any and I haven't seen any other implementation that uses them. I'd like to add one transformer to this PR but have no clue which practical transformer to support.

@d-v-b
Copy link

d-v-b commented Jul 9, 2024

I'm not aware of any! Maybe you could start with an IdentityTransformer that essentially implements f(x) -> x as a placeholder, then add real transformers if / when people start using them?

@zoj613
Copy link
Owner Author

zoj613 commented Jul 9, 2024

I'm not aware of any! Maybe you could start with an IdentityTransformer that essentially implements f(x) -> x as a placeholder, then add real transformers if / when people start using them?

That's essentially what i've done so far. I guess i'll just wait until the community starts using them. Thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metadata relating to metadata transformers relating to storage transformers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for storage transformers.
2 participants