Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nameserver14 is not implemented #920

Open
matsduf opened this issue May 25, 2021 · 7 comments
Open

Nameserver14 is not implemented #920

matsduf opened this issue May 25, 2021 · 7 comments
Assignees
@tgreenx
Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented May 25, 2021

Test case Nameserver14 is defined but it is not implemented in Nameserver.pm.
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label May 25, 2021
@matsduf matsduf added this to the v2021.2 milestone May 25, 2021
@mattias-p
Copy link
Member

Maybe we should remove the specification from v2021.1 and reinstate it once we have an implementation? That way it's clearer what is implemented and what's not.

@vlevigneron
Copy link
Contributor

I'll have a look. If it's easy to implement, I'll add the code this week.

@matsduf
Copy link
Contributor Author

matsduf commented May 25, 2021

@vlevigneron, we can wait until next release.

This was referenced May 26, 2021
Merged
Closed
@matsduf matsduf added the P-High Priority: Issue to be solved before other label Jun 17, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Nov 30, 2021
@matsduf
Copy link
Contributor Author

matsduf commented Nov 30, 2021

For v2022.1.

@matsduf matsduf mentioned this issue Nov 30, 2021
Merged
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jan 3, 2022
@tgreenx
Implementation of test procedure Nameserver14 (zonemaster#920)
e1d2a18
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jan 3, 2022
@tgreenx
Fix description of test procedure (zonemaster#920)
f31df1c
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jan 3, 2022
@tgreenx
Fix procedural check for empty SOA response in Nameserver14 (zonemas…
c59619d 
…ter#920)
@tgreenx tgreenx mentioned this issue Jan 3, 2022
Closed
@ghost ghost mentioned this issue Feb 16, 2022
Closed
@tgreenx tgreenx linked a pull request Apr 27, 2022 that will close this issue
Implementation of Nameserver14 #1033
Closed
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@marc-vanderwal
Copy link
Contributor

All links to Nameserver14 specifications are now broken. Is this issue still relevant?

@matsduf
Copy link
Contributor Author

matsduf commented Sep 13, 2024

It is stated in the specification

This test case actually combines the test options in test cases NAMESERVER10 and NAMESERVER11.

I am not convinced that it is really meaningful. In theory a name server can behave different in the combination, but I think it is less likely, an I think we should other specification and coding.

For me it can be removed.

@tgreenx tgreenx mentioned this issue Oct 15, 2024
Open
@tgreenx
Copy link
Contributor

tgreenx commented Oct 15, 2024

To be removed by #1390 and zonemaster/zonemaster#1300.

@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Oct 15, 2024
@tgreenx tgreenx assigned tgreenx and unassigned vlevigneron Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Milestone
v2024.2
Development

Successfully merging a pull request may close this issue.

Implementation of Nameserver14 tgreenx/zonemaster-engine
5 participants
@mattias-p @matsduf @vlevigneron @tgreenx @marc-vanderwal