Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No access at all for vehicle=no. Is it the expected behaviour? #2

Open
radim-asamm opened this issue May 26, 2021 · 1 comment
Open

Comments

@radim-asamm
Copy link

Hello,
consider a sample way tagged like this:

highway=track
tracktype=grade4
vehicle=no

This way is rendered as totally inaccessible due to the access_penalty expression (line 330).
Is this the intended behavior? I think no, as access=private is still allowed (even though penalized).
I have changed this behavior in this commit:
asamm/brouter@82d3cb7
Feedback welcome.
Thanks for your attention. Radim

@zossebart
Copy link
Owner

sorry for the late response.

yeah, the access penalties are a bit of a mess. I expanded the simple true/false logic of earlier versions to have a configurable penalty for private and bicycle=no cases (pre-github version, so you won't see the history here). Your change is ok for now (although it disables bicycle=no and bicycle=dismount handling alltogether).
Re-write of access handling is on my todo-list for a long time now, your issue triggered me to actually start thinking about it again. So expect changes regarding this topic from my side in the future. We may discuss penalties for different cases here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants