Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIS: Move journalAbbreviation to publicationTitle when empty, instead of copying? #3394

Open
AbeJellinek opened this issue Nov 25, 2024 · 4 comments · May be fixed by #3395
Open

RIS: Move journalAbbreviation to publicationTitle when empty, instead of copying? #3394

AbeJellinek opened this issue Nov 25, 2024 · 4 comments · May be fixed by #3395

Comments

@AbeJellinek
Copy link
Member

translators/RIS.js

Lines 1767 to 1770 in 4cadb3e

// hack for sites like Nature, which only use JA, journal abbreviation
if (item.journalAbbreviation && !item.publicationTitle) {
item.publicationTitle = item.journalAbbreviation;
}

Not sure if there's a reason we leave the "abbreviation" in both fields, but moving it might be more correct.

https://forums.zotero.org/discussion/119961/journalabbreviation-contains-full-journal-name-with-silverchair-translator

@AbeJellinek
Copy link
Member Author

(cc @adam3smith)

@adam3smith
Copy link
Collaborator

Note though that, for the Silverchair issue reported in that thread, this would only be a halfway solution: we wouldn't get the full title in the abbreviation anymore, but we'd throw out the existing abbreviation where it exists.

That said, I think moving makes more sense than copying, yes.

@AbeJellinek
Copy link
Member Author

Yeah, the RIS here is weird, though:

JO  - AVS Quantum Science
JA  - AVS Quantum Sci.

The translator parses JO and puts that into journalAbbreviation, then parses JA and throws it out because journalAbbreviation is already set.

Could try to do the move inline so that subsequent journalAbbreviations are recorded...

@adam3smith
Copy link
Collaborator

I figured for Silverchair we'd just run JO --> T2 as a regex replace in the translator. That looks consistent to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants