Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CSS variables and put under theme folder #76

Open
zouhir opened this issue Jan 20, 2018 · 3 comments
Open

Rename CSS variables and put under theme folder #76

zouhir opened this issue Jan 20, 2018 · 3 comments
Assignees

Comments

@zouhir
Copy link
Owner

zouhir commented Jan 20, 2018

variables Sass folder should have all the theme colour variations

config Sass file should map the theme variables to Jarvis specific variable names we use, I know sounds complicated but to explained further:

// variables.scss
// Belongs to the theme author not me
// Can have whatever names you want
// Go crazy

$sky-blue-aqua-color: #ccccc;
$tomato-red-error: #0f0f0f;
// config.scss
// Is what Jarvis uses
// Please map your theme colours to our colours here

@import 'theme-fantastic/variables.scss';

$color-dashboard-bg: $sky-blue-aqua-color;
etc..
@CHBaker
Copy link

CHBaker commented Mar 15, 2018

I don't really know sass, but I'd love to contribute (I can learn it). I can take this issue.

@cmgonzales
Copy link

is this issue still open?

@ForsakenHarmony
Copy link
Collaborator

zouhir rather busy nowadays I suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants