fix list spool file hang problem. #159
Conversation
Signed-off-by: Tian Na <[email protected]>
Signed-off-by: Tian Na <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #159 +/- ##
=======================================
Coverage ? 73.49%
=======================================
Files ? 77
Lines ? 981
Branches ? 128
=======================================
Hits ? 721
Misses ? 240
Partials ? 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This looks similar to the following PR:
Thanks for porting and enhancing the functionality and error message.
Curious if we can link the same issue on the changelog (issue number #156)
| @@ -23,17 +23,22 @@ export default class ListSpoolFilesByJobidHandler extends FTPBaseHandler { | |||
| this.log.debug("Listing spool files for job ID %s", params.arguments.jobId); | |||
| const job = await JobUtils.findJobByID(params.connection, params.arguments.jobId); | |||
| const files = job.spoolFiles; | |||
| if (files) { | |||
There was a problem hiding this comment.
Should we check the length as well?
if (files?.length > 0) { ...
Signed-off-by: Tian Na <[email protected]>
|
Hi @zFernand0, I think it fixed the issue #158 😊 |
|
Hi @zFernand0 , @traeok , @std4lqi , thank you for your review and good suggestions. I updated the code to check the files length as well. And also update unit test for no spool file scenario to improve test cover rate. Thank you! |
|
Merging without DCO check. See below issue for details 😋 Kudos to @traeok |
zFernand0
added
the
release-current
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
How to Test
Review Checklist
I certify that I have:
Additional Comments