From c610849b919f0f179fafed3f0c4552254263e67e Mon Sep 17 00:00:00 2001 From: zFernand0 <37381190+zFernand0@users.noreply.github.com> Date: Thu, 1 Aug 2024 14:29:57 -0400 Subject: [PATCH] review: address previous PR comment :yum: Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com> --- packages/zowe-explorer-api/CHANGELOG.md | 2 +- .../__unit__/trees/dataset/DatasetActions.unit.test.ts | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/zowe-explorer-api/CHANGELOG.md b/packages/zowe-explorer-api/CHANGELOG.md index 42074fa2ec..e95658f22c 100644 --- a/packages/zowe-explorer-api/CHANGELOG.md +++ b/packages/zowe-explorer-api/CHANGELOG.md @@ -38,7 +38,7 @@ All notable changes to the "zowe-explorer-api" extension will be documented in t - **Next Breaking:** Changed `ProfilesCache.convertV1ProfToConfig` method to be a static method that requires `ProfileInfo` instance as a parameter. - Added the `onVaultUpdate` VSCode event to notify extenders when credentials are updated on the OS vault by other applications. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994) - Added the `onCredMgrsUpdate` VSCode event to notify extenders when the local PC's credential manager has been updated by other applications. [#2994](https://github.com/zowe/zowe-explorer-vscode/pull/2994) -- Updated most function signatures for exported programmatic interfaces. Changes make developing with the Zowe Explorer API more efficient for extenders by showing which properties they can expect when calling our APIs. [#2952](https://github.com/zowe/zowe-explorer-vscode/issues/2952) +- **Breaking:** Updated most function signatures for exported programmatic interfaces. Changes make developing with the Zowe Explorer API more efficient for extenders by showing which properties they can expect when calling our APIs. [#2952](https://github.com/zowe/zowe-explorer-vscode/issues/2952) ### Bug fixes diff --git a/packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetActions.unit.test.ts b/packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetActions.unit.test.ts index e5c77d22f0..2a590c0af5 100644 --- a/packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetActions.unit.test.ts +++ b/packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetActions.unit.test.ts @@ -239,8 +239,7 @@ describe("Dataset Actions Unit Tests - Function createMember", () => { parentNode: blockMocks.datasetSessionNode, session: blockMocks.session, }); - const nonFavoriteLabel = parent.label; - parent.label = parent.label?.toString(); + const nonFavoriteLabel = parent.label?.toString(); parent.contextValue = Constants.DS_PDS_CONTEXT + Constants.FAV_SUFFIX; const mySpy = mocked(vscode.window.showInputBox).mockResolvedValue("testMember"); @@ -262,7 +261,7 @@ describe("Dataset Actions Unit Tests - Function createMember", () => { expect(mocked(zosfiles.Upload.bufferToDataSet)).toHaveBeenCalledWith( blockMocks.zosmfSession, Buffer.from(""), - (nonFavoriteLabel as string) + "(TESTMEMBER)", + nonFavoriteLabel + "(TESTMEMBER)", { responseTimeout: blockMocks.imperativeProfile.profile?.responseTimeout, }