Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting precise FDR values and plotting if values are 0 #209

Open
ThomasThaewel opened this issue Jun 4, 2023 · 1 comment
Open

Getting precise FDR values and plotting if values are 0 #209

ThomasThaewel opened this issue Jun 4, 2023 · 1 comment
Labels

Comments

@ThomasThaewel
Copy link

Thank you so much for the great implementation, I just have a couple of questions here.
If I use the standard gp.gsea function on my data (merged single cell dataset), I do get a lot of terms where FDR, NOM p-val and FWER are 0.
I use permutation_num=1000 like suggested in the snRNA-seq example, I read in the closed issues that this seems to be an issue if used with ssGSEA but is this the same case here for multiple samples?
The problem I run into then is that I can't use the suggested dot plot (gp.plot.dotplot(df_fin, column='FDR q-val', top_term=15, figsize=(4,8), cutoff=0.25)) since the FDR values of all top terms are 0.
Is there a way to get more precise FDR values or enable plotting without manually changing the values?
Thanks!

@zqfang
Copy link
Owner

zqfang commented Jun 7, 2023

see this FAQ: why FDR is 0.

when nomial-pvalue is 0, as does FDR.

  • one dirty trick to get a more precise pval/fdr is that replace the 0 with (1 / num_permutations).
  • or increase the permutation number

P.S. for prerank analysis, you may refer to use blitzgsea, which use an approximation method to fit a gamma distribution and you'll get very small pvalue.

@zqfang zqfang added the FAQ label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants