Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D effects of from view fail when screen orientation is switched #5

Open
wxyjay opened this issue Sep 2, 2024 · 0 comments
Open

3D effects of from view fail when screen orientation is switched #5

wxyjay opened this issue Sep 2, 2024 · 0 comments

Comments

@wxyjay
Copy link

wxyjay commented Sep 2, 2024

When the parent view presents a view via presentAsPuller(viewController, model: pullerModel), the 3D Scale of the parent view is incorrect when the screen orientation changes. I think this is because of

private lazy var screenWidth = { UIScreen.main.bounds.width }()
private lazy var screenHeight = { UIScreen.main.bounds.height }()

in PullerPresentationController, which fails to update to the latest screen size after the screen orientation changes.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant