Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not requiring RescriptCore to be opened globally #8

Open
reebalazs opened this issue Oct 20, 2024 · 0 comments
Open

Consider not requiring RescriptCore to be opened globally #8

reebalazs opened this issue Oct 20, 2024 · 0 comments

Comments

@reebalazs
Copy link

Is your feature request related to a problem? Please describe.
I have a project that still uses Belt. By opening Belt when RescriptCore is open, there are a lot of shadow warnings that I want to get rid of.

Sure there is a solution, I can use open! Belt everywhere in my codebase to get rid of the warnings, but this is also not perfect, as now both libraries are open, one shadowing the other.

Describe the solution you'd like
Using RescriptCore.Option instead of Option in the generated code would be easy, and then opening RescriptCore globally would not be required.

Additional context
While I like RescriptCore and I think it's the possible future, it is better to leave it up to the developers whether or not they want to open it globally in their project, and let pgtyped-rescript work either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant