Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Bug with zf-advise on a zf-modal #798

Open
mattgrande opened this issue Mar 29, 2016 · 2 comments
Open

Bug with zf-advise on a zf-modal #798

mattgrande opened this issue Mar 29, 2016 · 2 comments

Comments

@mattgrande
Copy link

I have a modal that looks like this:

<div zf-modal="" zf-advise id="formModal" role="dialog" animation-in="slideInUp" animation-out="slideOutDown">

And I'm subscribed to it like this:

FoundationApi.subscribe( 'formModal', function( action ) {
        console.info('subscribe/formModal', action);
});

That function gets the open, close, and active-false actions. However, it does not get the active-true action.

After some playing around in the Foundation code, it seems that the active-true is trying to be published against the <aside> tag that gets generated within the zf-modal, rather than the zf-modal itself.

In my case, I've been able to subscribe to an empty string:

FoundationApi.subscribe( '', function( action ) {
        console.info('subscribe/formModal', action);
});

but I can't imagine that's desired behaviour.

@soumak77
Copy link
Contributor

@mattgrande I'm not sure if it would help, but I made some changes to how zf-advise works in the framework (#741). I've only ever needed to use zf-advise for panels, not modals, so these changes may not fix your issue.

@mattgrande
Copy link
Author

Thanks @soumak77! I'll check that out in awhile!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants