Global MIDI binding not being saved/recalled in snapshot.

[riban-bw]

Describe the issue

It is possible to bind (learn) MIDI CC to a controller in chain or global mode. The chain mode binding is saved and recalled in ZS3 but global mode binding is not.

To Reproduce

Steps to reproduce the behavior:

1. Add a chain with a processor, e.g. zynsampler.
2. Press V5 knob twice or bold touch control and select "Global MIDI Learn..." to enter global MIDI learn mode, e.g. transport control.
3. Send a MIDI CC to zynthian so the control learns the CC, e.g. 1#60.
4. Save snapshot.
5. Recall snapshot.

Expected behaviour

Control has global MIDI binding.

Actual behaviour

Control has no MIDI binding.

Additional context

Global MIDI binding is not being saved to ZS3.

Configuration

Hardware

Raspberry Pi 5 Model B Rev 1.0
Audio: Tascam US-16x08
Display: MIPI DSI 800x480
Wiring: TOUCH_ONLY
I2C: Not detected
Profile: v5

System

Debian GNU/Linux 12 (bookworm)
Build Date: 2024-10-02
Memory: 20% (1613M/8064M)
Internal Storage: 10% (21G/234G)
Temperature: 46.6ºC
Overclock: None

MIDI & UI

Tuning: 440 Hz
Master Channel: 15
Preload Presets: Off
ZS3 (SubSnapShots): On
Power Save: 10 minutes
Audio Levels on Snapshots: On

Software

zyncoder: vangelis (727b73e) 
zynthian-ui: vangelis (68ac58a)
zynthian-sys: vangelis (ddc98c5)
zynthian-data: vangelis (ef38afe)
zynthian-webconf: vangelis (67a5a19)

[riban-bw]

This does work but behavior may seem strange. Global MIDI binding is linked to a MIDI device so it only works for the single device. If learned from a manually routed MIDI source (like I do when testing) then it won't be saved in ZS3 if that route is not to an existing device zmip.

I question whether this is the right approach. Should we filter MIDI CC by device in this way or via MIDI channel or offer user choice? This needs some consideration.

I do not see why @Lanfrancoiz3zlu is having an issue though if they do not change the MIDI input device they use.

[Lanfrancoiz3zlu]

Thanks @riban. Can't you consider replacing the encoder's work with another button? The encoder always works perfectly, but this means that you have to be inside Zynsampler (for example), start the Transport, exit Zynsampler, move from the mixer to another channel/instrument and start playing... meanwhile the backing track continues... Same thing for STOP and RECORD.