Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supertabs and ion-split-pane #437

Open
rodrigoGA opened this issue Jun 4, 2020 · 2 comments
Open

supertabs and ion-split-pane #437

rodrigoGA opened this issue Jun 4, 2020 · 2 comments

Comments

@rodrigoGA
Copy link

If you use supertabs inside an ion-split-pane it takes 100% of the screen and not the content
Please set --super-tab-width: 100%; as default value.

@Pacn91
Copy link

Pacn91 commented Oct 7, 2020

Just to complement the rodrigoGA answer you need to add the --super-tab-width: 100%; to the super-tabs, like so:

super-tabs {
    --super-tab-width: 100%;
}

The documentation talks about the --super-tab-width css property only in the super-tab but to fix the problem with ion-split-pane you need to add that property to the super-tabs and not to super-tab.

@nileshbandekar
Copy link

nileshbandekar commented Jun 11, 2021

There is problem in below condition in case of ion-split-pane i have corrected as below
node_modules@ionic-super-tabs\core\dist\esm\super-tab-button_2.entry.js

async onTouchStart(ev) {
        if (!this.scrollable) {
            return;
        }
        this.debug('onTouchStart', ev);
        const coords = pointerCoord(ev);
        const vw = this.clientWidth;
	const actualXPositionForSplit = window.innerWidth >= 758 ? window.innerWidth - this.clientWidth : 0; //note this
        if (coords.x < this.leftThreshold || coords.x - actualXPositionForSplit > vw - this.rightThreshold) {
            // ignore this gesture, it started in the side menu touch zone	
            return;
        }
        this.initialCoords = coords;
        this.lastPosX = coords.x;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants