Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to disable lint checks and build diem-forge package #28

Merged

Conversation

dboreham
Copy link

@dboreham dboreham commented Nov 2, 2024

Some investigation shows that it will take a while to fix all the clippy errors in the codebase, so this PR disables the checks for now.

Build failures in the main libra repo reveal that at least one package in this repo (diem-forge) was not built here, but is used in libra. This PR adds a build step for that package in order to catch those build failures in the right place.

@dboreham dboreham changed the title Add logic to disable lint checks since they fail at present Add logic to disable lint checks and build diem-forge package Nov 2, 2024
@dboreham dboreham requested a review from sirouk November 2, 2024 20:09
@0o-de-lally 0o-de-lally merged commit d52712d into 0LNetworkCommunity:release Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants