Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional repair #1501

Merged
merged 8 commits into from
May 30, 2024
Merged

Optional repair #1501

merged 8 commits into from
May 30, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented May 22, 2024

Changes

  • Removed Automatic repair in file operation, now if repair is required and status check is not turned off, sdk will return error with message repair_required.
  • Expose repair functionality in wasm, refer repairAllocation it only requires allocationID.
  • If the user does not want to repair and go ahead with file operations, status check will need to be turned off, it can be toggled using skipStatusCheck
  • To know the allocation and blobber status checkAllocStatus can be called, it will tell the user if allocation is ok,broken or needs to be repaired also with blobber status.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Hitenjain14 Hitenjain14 marked this pull request as ready for review May 28, 2024 17:17
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk feat/opt-repair
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4e6be22 into staging May 30, 2024
8 of 11 checks passed
@dabasov dabasov deleted the feat/opt-repair branch May 30, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants