-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read command #405
Open
lpoli
wants to merge
3
commits into
sprint-1.11
Choose a base branch
from
enhancement/lp-refactor-download
base: sprint-1.11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add read command #405
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package cmd | ||
|
||
import ( | ||
"os" | ||
"sync" | ||
|
||
"github.com/0chain/gosdk/zboxcore/sdk" | ||
"github.com/spf13/cobra" | ||
) | ||
|
||
// readerCmd represents reader command that downloads file from io.Reader interface provided in | ||
// gosdk | ||
var readerCmd = &cobra.Command{ | ||
Use: "read", | ||
Short: "read and store file from blobbers", | ||
Long: `This command will use io.ReadSeekCloser interface provided by Allocation object in gosdk to read file | ||
from blobbers`, | ||
Args: cobra.MinimumNArgs(0), | ||
Run: func(cmd *cobra.Command, args []string) { | ||
fflags := cmd.Flags() // fflags is a *flag.FlagSet | ||
if !(fflags.Changed("remotepath") || fflags.Changed("authticket")) { | ||
PrintError("Error: remotepath / authticket flag is missing") | ||
os.Exit(1) | ||
} | ||
|
||
remotePath := cmd.Flag("remotepath").Value.String() | ||
authTicket := cmd.Flag("authticket").Value.String() | ||
lookupHash := cmd.Flag("lookuphash").Value.String() | ||
verifyDownload, err := cmd.Flags().GetBool("verifydownload") | ||
if err != nil { | ||
PrintError("Error: ", err) | ||
os.Exit(1) | ||
} | ||
|
||
thumbnail, err := cmd.Flags().GetBool("thumbnail") | ||
if err != nil { | ||
PrintError("Error: ", err) | ||
os.Exit(1) | ||
} | ||
|
||
contentMode := sdk.DOWNLOAD_CONTENT_FULL | ||
if thumbnail { | ||
contentMode = sdk.DOWNLOAD_CONTENT_THUMB | ||
} | ||
|
||
localPath := cmd.Flag("localpath").Value.String() | ||
allocationID := cmd.Flag("allocation").Value.String() | ||
|
||
numBlocks, _ := cmd.Flags().GetInt("blockspermarker") | ||
wg := &sync.WaitGroup{} | ||
wg.Add(1) | ||
var allocationObj *sdk.Allocation | ||
if authTicket != "" { | ||
allocationObj, err = sdk.GetAllocationFromAuthTicket(authTicket) | ||
} else { | ||
if allocationID == "" { | ||
PrintError("Both authtoken and allocationID are empty") | ||
os.Exit(1) | ||
} | ||
allocationObj, err = sdk.GetAllocation(allocationID) | ||
} | ||
|
||
if err != nil { | ||
PrintError("Error fetching the allocation", err) | ||
os.Exit(1) | ||
} | ||
|
||
err = allocationObj.DownloadFromReader( | ||
remotePath, localPath, lookupHash, authTicket, contentMode, verifyDownload, uint(numBlocks)) | ||
if err != nil { | ||
PrintError("Error: ", err) | ||
os.Exit(1) | ||
} | ||
PrintError("Download successful") | ||
}, | ||
} | ||
|
||
func init() { | ||
rootCmd.AddCommand(readerCmd) | ||
readerCmd.PersistentFlags().String("allocation", "", "Allocation ID") | ||
readerCmd.PersistentFlags().String("remotepath", "", "Remote path to download") | ||
readerCmd.PersistentFlags().String("localpath", "", "Local path of file to download") | ||
readerCmd.PersistentFlags().String("authticket", "", "Auth ticket fot the file to download if you dont own it") | ||
readerCmd.PersistentFlags().String("lookuphash", "", "The remote lookuphash of the object retrieved from the list") | ||
readerCmd.Flags().BoolP("thumbnail", "t", false, "pass this option to download only the thumbnail") | ||
|
||
readerCmd.Flags().IntP("blockspermarker", "b", 10, "pass this option to download multiple blocks per marker") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's use |
||
readerCmd.Flags().BoolP("verifydownload", "v", false, "pass this option to verify downloaded blocks") | ||
|
||
readerCmd.MarkFlagRequired("allocation") | ||
readerCmd.MarkFlagRequired("localpath") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use
verify
to keep it short