Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #498 from 0chain/hm90121-patch-1 #540

Open
wants to merge 19 commits into
base: staging
Choose a base branch
from

Conversation

devyetii
Copy link
Collaborator

Update README.md

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

Kishan-Dhakan and others added 12 commits September 8, 2023 15:23
* Updated self hosted macos-runner & windows-runner

* updated self hosted runners
* Fix upload --web-streaming

Update gosdk to use correct ffmpeg commands

* Fix tests

* fix(gomod): upgraded gosdk with latest sprint-1.11

* chore(gomod): go mod tidy

---------

Co-authored-by: Lz <[email protected]>
* debug windows builds

* start builds on PRs

* remove un-used targets

* fix syntax error

* run only windows

* printend

* remove set GITHUB_ENV

* install make

* install choco

* set choco install path

* build-windows

* install zip

* also include dll files in the zip file

* comment out upload-release-action git action

* also install unzip

* cleanup release

* cleanup workspace

* overwrite current files while unzipping

* add back gosdk.yaml

* use .yml extension

* actions checkout

* use docker to build linux binary

* lsb_release print
This reverts commit 33f24ae, reversing
changes made to 46d3112.
@devyetii devyetii requested a review from hm90121 October 31, 2023 07:22
Copy link
Contributor

@hm90121 hm90121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-1.11 November 1, 2023 22:09
# Conflicts:
#	.github/workflows/build-zbox.yaml
#	.github/workflows/release-zboxcli.yml
#	README.md
@devyetii devyetii changed the base branch from sprint-1.11 to staging November 2, 2023 19:54
This reverts commit 8061495, reversing
changes made to 4e92da1.
@boddumanohar boddumanohar changed the base branch from staging to sprint-1.11 November 13, 2023 19:18
@boddumanohar boddumanohar changed the base branch from sprint-1.11 to staging November 13, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants