-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #498 from 0chain/hm90121-patch-1 #540
Open
devyetii
wants to merge
19
commits into
staging
Choose a base branch
from
update-readme-staging
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
* Updated self hosted macos-runner & windows-runner * updated self hosted runners
* Fix upload --web-streaming Update gosdk to use correct ffmpeg commands * Fix tests * fix(gomod): upgraded gosdk with latest sprint-1.11 * chore(gomod): go mod tidy --------- Co-authored-by: Lz <[email protected]>
Update gosdk
* debug windows builds * start builds on PRs * remove un-used targets * fix syntax error * run only windows * printend * remove set GITHUB_ENV * install make * install choco * set choco install path * build-windows * install zip * also include dll files in the zip file * comment out upload-release-action git action * also install unzip * cleanup release * cleanup workspace * overwrite current files while unzipping * add back gosdk.yaml * use .yml extension * actions checkout * use docker to build linux binary * lsb_release print
Update README.md
hm90121
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Revert "Merge pull request #498 from 0chain/hm90121-patch-1"
# Conflicts: # go.mod # go.sum
# Conflicts: # .github/workflows/build-zbox.yaml # .github/workflows/release-zboxcli.yml # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md
A brief description of the changes in this PR:
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):