Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add different naming for the different results of Bridge operations #324

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

YarikRevich
Copy link
Collaborator

No description provided.

@YarikRevich YarikRevich added the enhancement New feature or request label Nov 8, 2023
@YarikRevich YarikRevich self-assigned this Nov 8, 2023
Copy link
Contributor

@devyetii devyetii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YarikRevich YarikRevich merged commit 7c0d897 into sprint-1.11 Nov 9, 2023
7 checks passed
@YarikRevich YarikRevich deleted the fix/mint-result-naming branch November 9, 2023 13:29
dabasov added a commit that referenced this pull request Dec 19, 2023
* feature: synchronized up-to-date DEX bridge interface

* feature: updated gosdk version

* fix: fixed bugs

* fix: fixed bugs

* Silent the zcnbridge verbose logs when `--silent

* use 0box-sdk logger for zcnbridge (#304)

* update gosdk

* update gosdk

* update gosdk, fix errors

* Update/self hosted runner (#308)

* update self hosted runner

* updated self hosted runner

* updated gosdk

* updated gosdk

* updated gosdk

* update gosdk

* use msys2 to build windows binaries (#317)

* use msys2 to build windows binaries

* add build-windows in release-wallet.yml

* add actions checkout

* Feature: integrate token swap logic into WZCN burn command (#316)

* feature: added swap logic

* feature: added swap logic for burn wzcn command

* fix: replaced gosdk

* fix: fixed bugs

* fix: fixed bugs

* feature: replaced confusing param naming

* fix: updated gosdk version

---------

Co-authored-by: Yury <[email protected]>

* Fix wrong unit compare (#318)

* Add option to mint-zcn for specific burn txn (#322)

* Fix: add different naming for the different results of Bridge operations  (#324)

* fix: added different result messaging for different cases of bridge operations

* fix: debug line

* fix: removed debug line

* Feature: add reset nonce command (#329)

* feature: add reset nonce command

* fix: remove debug gosdk version

* feature: update gosdk version

* update gosdk (#326)

* update gosdk

* revert useless changes

---------

Co-authored-by: Yury <[email protected]>

* updated gosdk

* add runner (#321)

Co-authored-by: Manohar Reddy <[email protected]>

* update gosdk (#331)

* Feature: add BNT, USDC and EURC tokens for Swap (#327)

* feature: add multiple tokens for swap

* feature: fixed ERC20 approve

* feature: made DEX operations consistent with web-apps

* fix: fixed swap approval

* feature: update go.mod

* fix: fixed bug

* feature: updated gosdk

* Updated gosdk (#332)

* Add option to select eth address index (#333)

* Add --account_index option (#334)

* Add bip32 option to import account (#335)

* Feature: implement fork per run strategy (#336)

* feature: added fork creation

* feature: improved Tenderly creation flow

* update gosdk (#337)

* feature: added custom block number during Tenderly fork creation (#340)

* upgrade GoSDK to sprint-1.11 (#339)

Co-authored-by: service-0chain <[email protected]>

* upgrade GoSDK to sprint-1.11 (#341)

Co-authored-by: service-0chain <[email protected]>

* upgrade GoSDK to sprint-1.11 (#342)

Co-authored-by: service-0chain <[email protected]>

* upgrade GoSDK to sprint-1.11 (#343)

Co-authored-by: service-0chain <[email protected]>

* update gosdk to v1.11.0 (#347)

---------

Co-authored-by: YarikRevich <[email protected]>
Co-authored-by: Yaroslav Svitlytskyi <[email protected]>
Co-authored-by: Yaroslav Svitlytskyi <[email protected]>
Co-authored-by: peterlimg <[email protected]>
Co-authored-by: Manohar Reddy <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
Co-authored-by: dabasov <[email protected]>
Co-authored-by: peterlimg <[email protected]>
Co-authored-by: Ebrahim Gomaa <[email protected]>
Co-authored-by: Tapish Sinha <[email protected]>
Co-authored-by: Jayash Satolia <[email protected]>
Co-authored-by: service-0chain <[email protected]>
Co-authored-by: service-0chain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants