Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Machine Learning Interpretability #325

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Add Machine Learning Interpretability #325

merged 2 commits into from
Oct 28, 2022

Conversation

othrbot
Copy link

@othrbot othrbot commented Oct 28, 2022

Pull request from @matheusgmaia.

[ boilerplate snipped ]

Add awesome-machine-learning-interpretability
@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-matheusgmaia on 2019-10-26 23:06 says: unicorn

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-vinibeloni on 2019-10-28 01:23 says: For me, its okay. Thanks for contribution!

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-sindresorhus on 2019-10-28 06:09 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-sindresorhus on 2019-10-28 06:10 says:

For me, its okay. Thanks for contribution!

@-vinibeloni Please do a better effort when reviewing. This is very far from following the guidelines.

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-willeastcott on 2019-10-28 22:23 says: Hi @-matheusgmaia. Here are some pointers for things you might want to address if you want your PR to be merged:

  • The heading title of your list should be in title case format: # Awesome Name of List.
    ✅ Awesome Machine Learning Interpretability
    ❌ awesome-machine-learning-interpretability
  • Includes a project logo/illustration whenever possible (for your list, there may not be an image though).
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.

Also, consider sticking to the following format for link items:

Link - Description.

Often, you just have long descriptive links or links with no description.

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-matheusgmaia on 2019-10-28 23:52 says: Thanks for the feedback.

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-maehr on 2019-10-29 16:03 says: Hi @-matheusgmaia

Thanks a lot for this list.

I recommend you use awesome-lint. It points to these shortcomings of your draft.

  README.md:160:3
  ✖    1:1    Main heading must be in title case                                                                                 remark-lint:awesome/heading
  ✖    1:1    Missing License section                                                                                            remark-lint:awesome/license
  ✖    1:1    Missing or invalid Table of Contents                                                                               remark-lint:awesome/toc
  ✖    1:48   Invalid badge source                                                                                               remark-lint:awesome/badge
  ✖    9:67   Text "github" should be written as "GitHub"                                                                        remark-lint:awesome/spell-check
  ✖   64:3    Invalid list item link URL                                                                                         remark-lint:awesome/list-item
  ✖  143:4    Text "Youtube" should be written as "YouTube"                                                                      remark-lint:awesome/spell-check
  ✖  146:109  List item link and description must be separated with a dash                                                       remark-lint:awesome/list-item
  ✖  148:3    Link to https://www.algoaware.eu/ is dead                                                                          remark-lint:no-dead-urls
  ✖  160:3    Link to https://www.oreilly.com/ideas/you-created-a-machine-learning-application-now-make-sure-its-secure is dead  remark-lint:no-dead-urls
  ✖  207:80   List item link and description must be separated with a dash                                                       remark-lint:awesome/list-item
  ✖  231:80   List item link and description must be separated with a dash                                                       remark-lint:awesome/list-item

  12 errors

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-zmedelis on 2019-11-11 06:21 says: This is not explicitly in contribution guidelines but under Python section you have links to zip files

* [Bayesian Case Model](https://users.cs.duke.edu/~cynthia/code/BCM.zip)
* [Bayesian Rule List (BRL)](https://users.cs.duke.edu/~cynthia/code/BRL_supplement_code.zip)
* [Falling Rule List (FRL)](https://users.cs.duke.edu/~cynthia/code/falling_rule_list.zip)

Items should link to a project/product pages with some descriptions and docs. If you need to have the above links maybe its better to point to the home page (first link 'Bayesian Case Model' case) https://users.cs.duke.edu/~cynthia/code.html at least it as a reference to an academic paper.

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-sindresorhus on 2019-12-16 13:58 says: @-matheusgmaia Bump

@othrbot
Copy link
Author

othrbot commented Oct 28, 2022

@-GustavBertram on 2020-01-06 21:30 says: @-matheusgmaia You should make a PR to fix the issues, as requested by @-jphall663 here: jphall663/awesome-machine-learning-interpretability#23

@akvadrako akvadrako merged commit 6e79f32 into main Oct 28, 2022
@akvadrako akvadrako deleted the pull/1644 branch October 28, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants