Bugfix/issue#5 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mwolf43, with Git in general, it's better to avoid combining a bugfix and new feature in a single pull request. Thank you, though. (I am not affiliated with 0install.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm using 0install for the distribution own developed tools on Linux and Windows for a small and private group of users. I came across the problem that this implementation of 0publish seemed not to be fully compatible with Python 3, which was a blocker on my Ubuntu system. On the other hand it produced errors on Windows (see related commit messages).
Additionally I added support for the usage of GPG passphrases according to the other implementation, Zero Install Publishing Tools for Windows.
The changes have been tested on Linux and Windows so far. Please review them and integrate them into the upstream repository, if possible. I'm not a Python programmer, so please forgive me when my code is not of the required quality. In this case I would happy to see your improvements ;-) Thanks!