feat: album 생성, 수정, 삭제 API #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
username1103
approved these changes
Nov 19, 2023
Comment on lines
+44
to
+63
| public static UserAlbum createHost(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.HOST); | ||
| } | ||
|
|
||
| public static UserAlbum createMember(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.MEMBER); | ||
| } | ||
|
|
||
| public static UserAlbum createGuest(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.GUEST); | ||
| } | ||
|
|
||
| private static UserAlbum createUserAlbum( | ||
| @Nonnull Long albumId, @Nonnull Long userId, @Nonnull UserAlbumRole role) { | ||
| UserAlbum userAlbum = new UserAlbum(); | ||
| userAlbum.albumId = albumId; | ||
| userAlbum.userId = userId; | ||
| userAlbum.role = role; | ||
| return userAlbum; | ||
| } |
| @Nonnull Long userId, | ||
| List<Long> memberUserIds, | ||
| List<Long> guestUserIds) { | ||
| Set<Long> userIds = new HashSet<>(); |
There was a problem hiding this comment.
Set을 사용한 이유가 중복해서 사용자가 추가되지 않도록 하기위해서지?
밑에서 add 해서 새롭게 추가되었을 때만 디비에 적재하는거구.
There was a problem hiding this comment.
딱 맞음! 동일 사용자가 여러 권한을 갖지 않도록.
| parameterWithName("albumId") | ||
| .description("앨범 아이디") | ||
| .type(SimpleType.NUMBER)) | ||
| .requestSchema(Schema.schema("UpdateAlbumRequest")) |
There was a problem hiding this comment.
requestSchema만 지정해도 swagger가 잘나오나 궁금해서요. 내부 필드들에 대한 선언 없이도 잘나오나요??
Comment on lines
+105
to
+128
| Set<Long> userIds = new HashSet<>(); | ||
|
|
||
| UserAlbum hostUserAlbum = UserAlbum.createHost(albumId, userId); | ||
|
|
||
| userAlbumRepository.save(hostUserAlbum); | ||
| userIds.add(userId); | ||
|
|
||
| if (memberUserIds != null) { | ||
| for (Long memberId : memberUserIds) { | ||
| if (userIds.add(memberId)) { | ||
| UserAlbum memberUserAlbum = UserAlbum.createMember(albumId, memberId); | ||
| userAlbumRepository.save(memberUserAlbum); | ||
| } | ||
| } | ||
| } | ||
| if (guestUserIds != null) { | ||
| for (Long guestId : guestUserIds) { | ||
| if (userIds.add(guestId)) { | ||
| UserAlbum guestUserAlbum = UserAlbum.createGuest(albumId, guestId); | ||
| userAlbumRepository.save(guestUserAlbum); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
생성쪽과 동일한 로직인 것 같은데 맞다면 메서드로 빼도 좋을 것 같아
pythonstrup
approved these changes
Nov 21, 2023
Comment on lines
+44
to
+63
| public static UserAlbum createHost(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.HOST); | ||
| } | ||
|
|
||
| public static UserAlbum createMember(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.MEMBER); | ||
| } | ||
|
|
||
| public static UserAlbum createGuest(@Nonnull Long albumId, @Nonnull Long userId) { | ||
| return createUserAlbum(albumId, userId, UserAlbumRole.GUEST); | ||
| } | ||
|
|
||
| private static UserAlbum createUserAlbum( | ||
| @Nonnull Long albumId, @Nonnull Long userId, @Nonnull UserAlbumRole role) { | ||
| UserAlbum userAlbum = new UserAlbum(); | ||
| userAlbum.albumId = albumId; | ||
| userAlbum.userId = userId; | ||
| userAlbum.role = role; | ||
| return userAlbum; | ||
| } |
Comment on lines
+41
to
+44
| if (album != null) { | ||
| album.softDelete(); | ||
| entityManager.merge(album); | ||
| } |
There was a problem hiding this comment.
- 혹시 위에서 find를 했는데 entityManager.merge(album)를 꼭 사용해야할 이유가 있을까요?
- merge를 안 해주더라도 JPA 더티 체킹으로 자동 업데이트 되지 않을까하는 생각이 들어서요!
- 더티 체킹 참고 자료
- (제가 모르는 무엇인가) 이유가 있다면 merge를 사용해도 상관 없을 것 같습니다.
There was a problem hiding this comment.
감사해요. merge 사용한 부분들 체크해보고 불필요한 부분은 제거하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
고민
참고사항
#29