-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Updates 20 #486
base: main
Are you sure you want to change the base?
General Updates 20 #486
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ffe01a3
to
8507d5b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
127f95d
to
1983725
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Lamparter <[email protected]>
Nooooo........ |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed 260 except UI changes and Octicons gen Program.cs
|
||
string str = fileName[..^4].Replace('-', '_'); | ||
|
||
string fileName = Path.GetFileNameWithoutExtension(path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why without extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩 I don't even remember writing this...
2414368
to
389b20e
Compare
Youch when I used to use emoji in commits 😬 |
Alright. Let's get this merged. |
Make it colourful again!