Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Updates 20 #486

Draft
wants to merge 71 commits into
base: main
Choose a base branch
from
Draft

General Updates 20 #486

wants to merge 71 commits into from

Conversation

Lamparter
Copy link
Collaborator

Make it colourful again!

@Lamparter Lamparter self-assigned this Jul 16, 2024
@Lamparter Lamparter added this to the FluentHub v1.0.0 milestone Jul 16, 2024
@0x5bfa

This comment was marked as outdated.

@0x5bfa 0x5bfa changed the title Refresh app GitHub: Improve README.md Jul 17, 2024
@Lamparter

This comment was marked as outdated.

@Lamparter Lamparter changed the title GitHub: Improve README.md Small fixes / refresh FluentHub Jul 18, 2024
@0x5bfa 0x5bfa added general updates This PR is an official general update. and removed type/code-quality labels Jul 20, 2024
@Lamparter Lamparter changed the title Small fixes / refresh FluentHub General Updates 20 Jul 20, 2024
@Lamparter Lamparter closed this Jul 20, 2024
@Lamparter Lamparter deleted the lamparter/refactor branch July 20, 2024 10:53
@Lamparter Lamparter restored the lamparter/refactor branch July 20, 2024 10:53
@Lamparter Lamparter reopened this Jul 20, 2024
@Lamparter Lamparter linked an issue Jul 21, 2024 that may be closed by this pull request
66 tasks
@Lamparter Lamparter force-pushed the lamparter/refactor branch from ffe01a3 to 8507d5b Compare July 21, 2024 13:31
@Lamparter

This comment was marked as resolved.

@0x5bfa

This comment was marked as outdated.

@Lamparter

This comment was marked as outdated.

.github/README.md Outdated Show resolved Hide resolved
@0x5bfa 0x5bfa changed the title General Updates 20 Code Quality: Added Octicons latest available Sep 29, 2024
@Lamparter
Copy link
Collaborator Author

Nooooo........

@Lamparter Lamparter changed the title Code Quality: Added Octicons latest available General Updates 20 Sep 29, 2024
@Lamparter

This comment was marked as resolved.

Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed 260 except UI changes and Octicons gen Program.cs

src/FluentHub.App/Views/MainPage.xaml.cs Show resolved Hide resolved
src/FluentHub.App/Strings/README.md Show resolved Hide resolved

string str = fileName[..^4].Replace('-', '_');

string fileName = Path.GetFileNameWithoutExtension(path);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why without extension?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩 I don't even remember writing this...

@Lamparter
Copy link
Collaborator Author

Youch when I used to use emoji in commits 😬
Looks so ugly...

@Lamparter
Copy link
Collaborator Author

Alright. Let's get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general updates This PR is an official general update.
Projects
Status: 🏗 In progress
3 participants