Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit changes #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Audit changes #1

wants to merge 14 commits into from

Conversation

sbauch
Copy link
Contributor

@sbauch sbauch commented Apr 24, 2022

Implements recommended changes. Generally we are adding more data to the OffchainError lookup and signing all of that data on this API. The contract then has more confidence between the verifications it performs.

  • handles new shape of callData param from OffchainLookup error
  • uses chain ID values from callData to be more chain agnostic - ENV no longer needs to specify RPC URLs, just an Infura key, meaning we dont need separate instances for testnets
  • will not sign bundle if provided nonce does not match contract state nonce for the signer address

@sbauch sbauch marked this pull request as ready for review May 15, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant