Skip to content

Commit

Permalink
chore: rm comment, fix slither
Browse files Browse the repository at this point in the history
  • Loading branch information
DhairyaSethi committed Aug 16, 2023
1 parent 4994dfd commit fbc0331
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contracts/child/validator/ValidatorSet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ contract ValidatorSet is IValidatorSet, ERC20VotesUpgradeable, System {
slashedAmounts[i] = (balanceOf(validatorsToSlash[i]) * SLASHING_PERCENTAGE) / 100;
_burn(validatorsToSlash[i], slashedAmounts[i]); // partially unstake validator
// slither-disable-next-line mapping-deletion
delete withdrawals[validatorsToSlash[i]]; // ? do we need to remove pending withdrawals
delete withdrawals[validatorsToSlash[i]]; // remove pending withdrawals
unchecked {
++i;
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/root/staking/CustomSupernetManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ contract CustomSupernetManager is ICustomSupernetManager, Ownable2StepUpgradeabl
uint256 totalSlashedAmount;
for (uint256 i = 0; i < length; ) {
uint256 slashedAmount = (stakeManager.stakeOf(validatorsToSlash[i], id) * SLASHING_PERCENTAGE) / 100;
// slither-disable-next-line reentrancy-benign,reentrancy-events
// slither-disable-next-line reentrancy-benign,reentrancy-events,reentrancy-no-eth
stakeManager.slashStakeOf(validatorsToSlash[i], slashedAmount);
_removeIfValidatorUnstaked(validatorsToSlash[i]);
totalSlashedAmount += slashedAmount;
Expand Down

0 comments on commit fbc0331

Please sign in to comment.