Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gov, add initializers #298

Merged
merged 4 commits into from
Jul 14, 2023
Merged

fix: gov, add initializers #298

merged 4 commits into from
Jul 14, 2023

Conversation

ZeroEkkusu
Copy link
Member

Motivation

Additional changes requested.

Solution

  • Fetch from NetworkParams in ValidatorSet
  • Use initialize instead of constructor in NetworkParams and ForkParams
  • Update Forge tests

@QEDK
Copy link
Contributor

QEDK commented Jul 14, 2023

@ZeroEkkusu can you fix the hardhat tests?

@QEDK
Copy link
Contributor

QEDK commented Jul 14, 2023

@ZeroEkkusu also there seem to be two unresolved Slither issues.

@ZeroEkkusu
Copy link
Member Author

All issues have been resolved, Senpai! ✨

@ZeroEkkusu ZeroEkkusu requested a review from QEDK July 14, 2023 18:54
@QEDK QEDK merged commit 1b3941a into dev Jul 14, 2023
7 checks passed
@QEDK QEDK deleted the fix/gov branch July 14, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QEDK QEDK Awaiting requested review from QEDK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroEkkusu @QEDK