Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gov): pass epochSize #310

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix(gov): pass epochSize #310

merged 2 commits into from
Jul 27, 2023

Conversation

ZeroEkkusu
Copy link
Member

Motivation

Prevent epochSize changing mid-epoch.

Solution

Pass epochSize in commitEpoch of ValidatorSet and distributeRewards of RewardPool.

@wschwab wschwab requested a review from gretzke July 24, 2023 09:55
@coveralls
Copy link

coveralls commented Jul 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5643421694

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 78.813%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/child/validator/ValidatorSet.sol 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
contracts/child/validator/RewardPool.sol 1 0%
contracts/child/validator/ValidatorSet.sol 1 0%
Totals Coverage Status
Change from base Build 5574935285: 0.03%
Covered Lines: 1366
Relevant Lines: 1686
💛 - Coveralls

@gretzke gretzke merged commit 74f026e into dev Jul 27, 2023
7 checks passed
@gretzke gretzke deleted the fix/epoch-size branch July 27, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretzke gretzke gretzke approved these changes

@wschwab wschwab wschwab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeroEkkusu @coveralls @gretzke @wschwab