Update e2e with l1InfoTree + upgrade verifier to v2 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ignasirv
commented
Oct 7, 2024
ignasirv
commented
- Upgrade SP1 verifier to v2
- Update SP1 e2e test to use l1InfoTree
ignasirv
requested review from
invocamanman,
krlosMata and
laisolizq
as code owners
|
invocamanman
approved these changes
Oct 7, 2024
krlosMata
reviewed
Oct 7, 2024
| @@ -1,8 +1,6 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.20; | |||
|
|
|||
| // imported from: https://github.com/succinctlabs/sp1-contracts/blob/main/contracts/src/ISP1Verifier.sol | |||
There was a problem hiding this comment.
I think we should leave this comment
| @@ -4,9 +4,6 @@ pragma solidity ^0.8.20; | |||
| import {ISP1Verifier, ISP1VerifierWithHash} from "../v2/interfaces/ISP1Verifier.sol"; | |||
| import {PlonkVerifier} from "./PlonkVerifier.sol"; | |||
|
|
|||
| // Current deployments: https://github.com/succinctlabs/sp1-contracts/tree/main/contracts/deployments | |||
There was a problem hiding this comment.
I think we should leave this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.