Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop feijoa #318

Draft
wants to merge 246 commits into
base: develop
Choose a base branch
from
Draft

Develop feijoa #318

wants to merge 246 commits into from

Conversation

krlosMata
Copy link
Contributor

  • PR to check diffs

zkronos73 and others added 30 commits March 17, 2023 16:33
@zkronos73
first draft mem_align variable length
4fb5ac2
@zkronos73
executor and comments of mem_align variable length
101628f
@zkronos73
add POC of save/restore
8a40dd0
@hecmas
Modular arithmetic implemented
8d47716
@zkronos73
improvements on save/restore, reuse inX selectors to select registers
11d60ad
@zkronos73
improvements on test mstorex optimization
09a2f7c
@zkronos73
Package ready to test
acb3098
@zkronos73
update test mstorex
070387c
@hecmas
Adding two new helpers
8d233f1
@hecmas
Minor code improvements
8447a82
@hecmas
Updating comments
39331be
@hecmas
Testing the modular arithmetic in zkasm
7e833a5
@hecmas
Adding an extra helper to check the zero
7d3707d
@zkronos73
update test
d742d65
@zkronos73
Merge branch 'main' into feature/save-restore
a514191
@zkronos73
Merge remote-tracking branch 'origin/develop-feijoa' into feature/sav…
b5e01f5 
…e-restore
@zkronos73
fix constraint commented in a test
10ea5ae
@zkronos73
feature hash-bytes
9334279
@zkronos73
fix bug on rom lookup
72a7de2
@zkronos73
Merge branch 'feature/save-restore' into feature/hash-bytes
e37ee79
@zkronos73
basic version without selectors
a3698d5
@zkronos73
fixing some bugs and more additional tests
0462f6e
@zkronos73
fix tests of collection
b75af71
@zkronos73
Merge branch 'develop-feijoa' into feature/save-restore
4d099b5
@zkronos73
update zkasmcom dependecy
36461af
@zkronos73
Merge branch 'feature/save-restore' into feature/hash-bytes
b49e726
@zkronos73
add feature --all to zkasmtest and fix some bugs
9606b20
@zkronos73
Merge pull request #261 from 0xPolygonHermez/feature/save-restore
78f3122 
feature/save restore
@zkronos73
Merge pull request #263 from 0xPolygonHermez/feature/hash-bytes
44222da 
feature/hash bytes
@hecmas
Fixing the modular arith
48f487c
ignasirv and others added 28 commits April 12, 2024 10:01
@ignasirv
Only restore if save array is not empty
2c76ede
@ignasirv
Remove testvectors from package
06a2e9e
@krlosMata
Merge pull request #332 from 0xPolygonHermez/feature/save-restore
65b62fe 
Restore last save in case of fastDebugExit
@krlosMata
tag 10
182cead
@krlosMata
add package-lock.json with no devDependencies
8867bdf
@krlosMata
update e2e tests
6c67792
@krlosMata
Merge pull request #331 from 0xPolygonHermez/feature/tag-10
8c16b0f 
tag 10
@laisolizq
update versioned hash
b0d6c4a
@laisolizq
fix cntSha256
c8effcd
@zkronos73
remove load hash test
5aa93f0
@zkronos73
Merge branch 'develop-feijoa' into feature/collection-improvement
f505c34
@zkronos73
Merge pull request #293 from 0xPolygonHermez/feature/collection-impro…
6fb4505 
…vement

Diagnostic population and refactor
@zkronos73
remove fulltracer helpers tests on diagnostic
0547fed
@zkronos73
Merge pull request #338 from 0xPolygonHermez/fix/diagnostic-helpers-test
976c2cd 
remove fulltracer helpers tests on diagnostic
@zkronos73
fix an error with helpers call ARITH_BN254_ADDFP2 and ARITH_BN254_SUBFP2
89500d8
@zkronos73
litle improvement on helper test
ce5f243
@zkronos73
litle improvement on helper test
19f64da
@zkronos73
Merge pull request #339 from 0xPolygonHermez/fix/test-diagnostic-help…
ebba680 
…er-arith-bn254

fix an error with helpers call ARITH_BN254_ADDFP2 and ARITH_BN254_SUBFP2
@ignasirv
Merge pull request #337 from 0xPolygonHermez/feature/read-write-final…
f3d9824 
…-root

set read wrire addresses from final root
@zkronos73
update diagnostic test with finalWait label
862e91d
@zkronos73
Merge pull request #341 from 0xPolygonHermez/fix/diagnostic-finalwait…
0566981 
…-label

update diagnostic test with finalWait label
@laisolizq
fix computeZ
7431297
@krlosMata
Merge pull request #336 from 0xPolygonHermez/feature/versioned-hash
46561fb 
Feature/versioned hash
@laisolizq
update package json
3460dbe
@krlosMata
Merge pull request #343 from 0xPolygonHermez/feature/upate-package-json
9b5840f 
update package json
@laisolizq
fix commonjs
eb76f62
@laisolizq
fix commitment
cdff16a
@krlosMata
Merge pull request #345 from 0xPolygonHermez/feature/fix-computez
f3c1504 
Feature/fix computez
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zkronos73 zkronos73 added the feijoa Feijoa label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractasy fractasy Awaiting requested review from fractasy

Assignees
No one assigned
Labels
cla-signed feijoa Feijoa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krlosMata @zkronos73 @hecmas @ignasirv @laisolizq @RogerTaule