Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use QR codes with link indirection #481

Merged
merged 14 commits into from
Aug 29, 2023
Merged

feat: Use QR codes with link indirection #481

merged 14 commits into from
Aug 29, 2023

Conversation

x1m3
Copy link
Contributor

@x1m3 x1m3 commented Aug 18, 2023 •
edited
Loading

QRs codes now contain a link to return the full content of the QR. This increase scanning performance because there is less information inside the QR.

api-ui:

  • /v1/authentication/qrcode
  • /v1/credentials/{id}/qrcode
  • /v1/credentials/links/{id}/qrcode
  • /v1/qr-code
  • test /v1/qr-code

api:

  • /v1/{identifier}/claims/{id}/qrcode
  • /v1/qr-code
  • test /v1/qr-code

@x1m3 x1m3 requested a review from a team as a code owner August 18, 2023 14:55
@x1m3 x1m3 marked this pull request as draft August 18, 2023 14:59
martinsaporiti
martinsaporiti approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@martinsaporiti martinsaporiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javip97 javip97 marked this pull request as ready for review August 29, 2023 12:59
@javip97 javip97 merged commit 14b3e3b into develop Aug 29, 2023
3 checks passed
@javip97 javip97 deleted the PID-1210-issuer-node-use-link-in-qr-codes branch August 29, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javip97 javip97 javip97 approved these changes

@martinsaporiti martinsaporiti martinsaporiti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x1m3 @martinsaporiti @javip97