support profiles (#105)

* support profiles * support profiles * modify IPFS tests * MInor fix * Rollback rename * make findCredential private --------- Co-authored-by: Dimasik Kolezhniuk <[email protected]>
0xPolygonID · Jul 21, 2023 · 2390add · 2390add
1 parent 92ef8d6
commit 2390add
Show file tree

Hide file tree

Showing 29 changed files with 466 additions and 531 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -54,6 +54,7 @@ jobs:
 
       - name: Run Tests
         env:
+          IPFS_URL: ${{ secrets.IPFS_URL }}
           WALLET_KEY: ${{ secrets.WALLET_KEY }}
           RPC_URL: ${{ secrets.RPC_URL }}
           RHS_URL: ${{ secrets.RHS_URL }}

diff --git a/README.md b/README.md
@@ -33,6 +33,8 @@ To run them, please set following variables:
 export WALLET_KEY="...key in hex format"
 export RPC_URL="...url to polygon network rpc node"
 export RHS_URL="..reverse hash service url"
+export IPFS_URL="url for ipfs"
+
 ```
 
 And place actual circuits to `test/proofs/testdata`

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -74,7 +74,7 @@
   "dependencies": {
     "@iden3/js-crypto": "1.0.0",
     "@iden3/js-iden3-core": "1.0.0",
-    "@iden3/js-jsonld-merklization": "1.0.0",
+    "@iden3/js-jsonld-merklization": "1.0.1",
     "@iden3/js-jwz": "1.0.0",
     "@iden3/js-merkletree": "1.0.0",
     "@lumeweb/js-sha3-browser": "^0.8.1",

diff --git a/src/credentials/status/on-chain-revocation.ts b/src/credentials/status/on-chain-revocation.ts
@@ -66,21 +66,24 @@ export class OnChainResolver implements CredentialStatusResolver {
     issuer: string;
   } {
     const url = new URL(id);
-    if (!url.searchParams.has('contractAddress')) {
+    const contractId = url.searchParams.get('contractAddress');
+    const revocationNonceParam = url.searchParams.get('revocationNonce');
+
+    if (!contractId) {
       throw new Error('contractAddress not found');
     }
-    if (!url.searchParams.has('revocationNonce')) {
+    if (!revocationNonceParam) {
       throw new Error('revocationNonce not found');
     }
 
     const issuer = id.split('/')[0];
     if (!issuer) {
       throw new Error('issuer not found in credentialStatus id');
     }
+
     // TODO (illia-korotia): after merging core v2 need to parse contract address from did if `contractAddress` is not present in id as param
-    const contractId = url.searchParams.get('contractAddress');
-    const revocationNonce = parseInt(url.searchParams.get('revocationNonce')!, 10);
-    const parts = contractId!.split(':');
+    const revocationNonce = parseInt(revocationNonceParam, 10);
+    const parts = contractId.split(':');
     if (parts.length != 2) {
       throw new Error('invalid contract address');
     }