fix review

0xPolygonID · Oct 3, 2023 · 6ab80f6 · 6ab80f6
1 parent 35ffd74
commit 6ab80f6
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 12 deletions.
diff --git a/src/iden3comm/handlers/contract-request.ts b/src/iden3comm/handlers/contract-request.ts
@@ -45,7 +45,7 @@ export interface IContractRequestHandler {
  *
  * Allows to process ContractInvokeRequest protocol message
  *
- * @beta
+ * @public
 
  * @class ContractRequestHandler
  * @implements implements IContractRequestHandler interface
@@ -129,7 +129,7 @@ export class ContractRequestHandler implements IContractRequestHandler {
         did,
         {
           skipRevocation: query.skipClaimRevocationCheck ?? false,
-          challenge: opts.challange
+          challenge: opts.challenge
         }
       );
 

diff --git a/src/iden3comm/types/protocol/contract-request.ts b/src/iden3comm/types/protocol/contract-request.ts
@@ -28,5 +28,5 @@ export type ContractInvokeTransactionData = {
 /** ContractInvokeHandlerOptions represents contract invoke handler options */
 export type ContractInvokeHandlerOptions = {
   ethSigner: Signer;
-  challange?: bigint;
+  challenge?: bigint;
 };
diff --git a/src/identity/identity-wallet.ts b/src/identity/identity-wallet.ts
@@ -900,7 +900,7 @@ export class IdentityWallet implements IIdentityWallet {
 
     await this._storage.identity.saveIdentity({
       did: issuerDID.string(),
-      state: treeState ? treeState.state : latestTreeState.state,
+      state: treeState?.state ?? latestTreeState.state,
       isStatePublished: published,
       isStateGenesis: false
     });

diff --git a/src/storage/blockchain/zkp-verifier.ts b/src/storage/blockchain/zkp-verifier.ts
@@ -12,16 +12,12 @@ import { ZeroKnowledgeProofResponse } from '../../iden3comm';
  * @class ZKPVerifier
  */
 export class ZKPVerifier implements IZKPVerifier {
-  private readonly config: EthConnectionConfig;
-
   /**
    * Creates an instance of ZKPVerifier.
    * @public
    * @param {EthConnectionConfig} config - eth connection config
    */
-  constructor(config: EthConnectionConfig) {
-    this.config = config;
-  }
+  constructor(private readonly _config: EthConnectionConfig) {}
 
   /**
    * Submit ZKP Responses to ZKPVerifier contract.
@@ -38,9 +34,9 @@ export class ZKPVerifier implements IZKPVerifier {
     ethSigner: Signer,
     zkProofResponses: ZeroKnowledgeProofResponse[]
   ): Promise<Map<string, ZeroKnowledgeProofResponse>> {
-    this.config.chainId = chain_id;
+    this._config.chainId = chain_id;
 
-    const provider = new ethers.providers.JsonRpcProvider(this.config);
+    const provider = new ethers.providers.JsonRpcProvider(this._config);
     const verifierContract: ethers.Contract = new ethers.Contract(address, abi, provider);
     const contract = verifierContract.connect(ethSigner);
 

diff --git a/tests/handlers/contract-request.test.ts b/tests/handlers/contract-request.test.ts
@@ -278,7 +278,7 @@ describe('contact-request', () => {
 
     const options: ContractInvokeHandlerOptions = {
       ethSigner,
-      challange: BigInt(112312)
+      challenge: BigInt(112312)
     };
     const msgBytes = byteEncoder.encode(JSON.stringify(ciRequest));
     const ciResponse = await contractRequest.handleContractInvokeRequest(