feat: accept header #253
Open
feat: accept header #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmidyllic
requested changes
Aug 15, 2024
src/iden3comm/packers/jws.ts
Outdated
| @@ -102,6 +102,11 @@ export class JWSPacker implements IPacker { | |||
| return MediaType.SignedMessage; | |||
| } | |||
|
|
|||
| /** {@inheritDoc IPacker.getSupportedAlgorithms} */ | |||
| getSupportedAlgorithms(): AcceptJwsAlgorithms[] { | |||
vmidyllic
requested changes
Aug 27, 2024
src/iden3comm/packers/jws.ts
Outdated
| @@ -102,6 +103,38 @@ export class JWSPacker implements IPacker { | |||
| return MediaType.SignedMessage; | |||
| } | |||
|
|
|||
| /** {@inheritDoc IPacker.getEnvelop} */ | |||
| getEnvelop(): string { | |||
src/iden3comm/packers/jws.ts
Outdated
| } | ||
|
|
||
| /** {@inheritDoc IPacker.isSupported} */ | ||
| isSupported(profile: string) { |
feat: add support of submitZKPResponseV2 and prepareTxArgsSubmit
vmidyllic
reviewed
Sep 9, 2024
src/iden3comm/handlers/auth.ts
Outdated
| } | ||
|
|
||
| if (!supportedMediaTypes.length) { | ||
| throw new Error('no profile meets `access` header requirements'); |
There was a problem hiding this comment.
throw new Error('no packer with profile which meets access header requirements');
Comment
src/iden3comm/packageManager.ts
Outdated
| @@ -21,6 +21,21 @@ export class PackageManager implements IPackageManager { | |||
| this.packers = new Map<MediaType, IPacker>(); | |||
| } | |||
|
|
|||
| /** {@inheritDoc IPackageManager.isSupported} */ | |||
| isSupported(mediaType: MediaType, profile: string): boolean { | |||
There was a problem hiding this comment.
you should rename interface method to isProfileSupported too
src/iden3comm/packers/zkp.ts
Outdated
| @@ -174,6 +175,49 @@ export class ZKPPacker implements IPacker { | |||
| mediaType(): MediaType { | |||
| return MediaType.ZKPMessage; | |||
| } | |||
|
|
|||
| /** {@inheritDoc IPacker.getEnvelope} */ | |||
| getEnvelope(): string { | |||
There was a problem hiding this comment.
and in future I guess we will have potentially an array of strings even for one media type, maybe we should return an array of strings and rename methods to getSupportedProfiles()
* feat: add optional displayMethod to CredentialRequest * IDEN3_DISPLAY_METHOD
* add logic for removal of the credential with another status * add possibility to disable publishing of the genesis state
* update profile nonce, so it can be number or string * 1.19.0 * add validation check
* add spellcheck
vmidyllic
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.