Simplify withdrawals logic #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
force-pushed
the
withdrawals
branch
5 times, most recently
from
3f34c46
to
cf771a4
Compare
|
Hmm I have no idea why the CI is failing to kick off though 🤔 |
Merged
|
Lol, I've just opened this and seen that you did CI stuff here. #17 is probably superfluous |
|
It's fine we can merge it and I'll pull :) I was also bothered by the |
muursh
reviewed
Apr 18, 2024
| txn_ir[1].trie_roots_after.state_root = final_trie_state.state.hash(); | ||
| } | ||
| } | ||
| last_inputs.withdrawals = withdrawals; |
There was a problem hiding this comment.
I'll be honest this made me double take at first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf 0xPolygonZero/zk_evm#167