Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_bootstrap_kernel column #1189

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Remove is_bootstrap_kernel column #1189

merged 1 commit into from
Aug 17, 2023

Conversation

Nashtare
Copy link
Collaborator

Now that CPU cycles are identified by the sum of the op instruction flags, we can do the same for the kernel bootstrapping flag, which are exactly the rows that are not CPU cycles.

@Nashtare Nashtare added this to the Optimization - Phase 1 milestone Aug 17, 2023
@Nashtare Nashtare self-assigned this Aug 17, 2023
npwardberkeley
npwardberkeley approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@npwardberkeley npwardberkeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nashtare Nashtare merged commit eb7bb46 into 0xPolygonZero:main Aug 17, 2023
2 checks passed
@Nashtare Nashtare deleted the remove_is_bootstrap_kernel_flag branch August 17, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npwardberkeley npwardberkeley npwardberkeley approved these changes

Assignees

@Nashtare Nashtare

Labels
None yet
Projects
None yet
Milestone
Optimization
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashtare @npwardberkeley